[ 
https://issues.apache.org/jira/browse/SLING-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181747#comment-14181747
 ] 

Oliver Lietz commented on SLING-3985:
-------------------------------------

Looking again closer at it, we already use 3.2.0 in tests and I realized that 
{{EventingThreadPool}} is only used internally when trying to create a 
bootstrap integration test for Karaf Launchpad a while back (which didn't 
work). The uncommon pattern of publishing a concrete class as service and the 
usage of {{EventingThreadPool}} in {{AbstractJobQueue}} (1, 2) still look 
strange to me. What is the purpose and what is the benefit of not updating?

1.
{noformat}
        if ( config.getOwnThreadPoolSize() > 0 ) {
            this.threadPool = new 
EventingThreadPool(services.threadPoolManager, config.getOwnThreadPoolSize());
        } else {
            this.threadPool = Environment.THREAD_POOL;
        }
{noformat}

2.
{noformat}
        if ( this.configuration.getOwnThreadPoolSize() > 0 ) {
            ((EventingThreadPool)this.threadPool).release();
        }
{noformat}

> update dependency Sling Commons Threads to 3.2.0
> ------------------------------------------------
>
>                 Key: SLING-3985
>                 URL: https://issues.apache.org/jira/browse/SLING-3985
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: Event 3.3.14
>            Reporter: Oliver Lietz
>            Assignee: Carsten Ziegeler
>            Priority: Minor
>             Fix For: Event 3.4.2
>
>         Attachments: SLING-3985.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to