[ 
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232082#comment-14232082
 ] 

Stefan Seifert commented on SLING-4212:
---------------------------------------

i had only a brief look at the patch - it seems you (or your IDE) reformatted a 
lot of lines, so its difficult to tell what has changed, and what is only 
reformatted (esp. in ResourcePathInjector.java).
can you reproduce the patch and make sure only the lines really changed are 
included?

> Sling Models: Allow multiple values from ValueMap in the resource-path 
> injector
> -------------------------------------------------------------------------------
>
>                 Key: SLING-4212
>                 URL: https://issues.apache.org/jira/browse/SLING-4212
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: santiago garcĂ­a pimentel
>
> The current implementation of the resource-path injector does not support 
> multiple values. I think it could be useful to inject a list of paths from 
> the valuemap.
>  I have created a small patch to allow this. Right now it only allows them 
> from the value map since I didn't want to change the API without consulting 
> you first. I you agree I can do this change as well. I also added a test case 
> for it.
> You can see a pull request in https://github.com/apache/sling/pull/51
> If there anything I can do to improve this patch, please let me know.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to