[ 
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246879#comment-14246879
 ] 

Stefan Seifert commented on SLING-4212:
---------------------------------------

i my view this would be most consistent:
# field injection = mandatory: succeeds when all items could be injected, fails 
if only some or none could be injected
# field injection = optional: succeeds always, may inject none, some or all 
items

whether the mandatory/optional status is controlled on field level with 
@Optional or @Required, or via custom annotation, or via default injection 
strategy should be irrelevant.

> Sling Models: Allow multiple values from ValueMap in the resource-path 
> injector
> -------------------------------------------------------------------------------
>
>                 Key: SLING-4212
>                 URL: https://issues.apache.org/jira/browse/SLING-4212
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: santiago garcĂ­a pimentel
>         Attachments: resourcePath-API.patch, resourcePath.patch
>
>
> The current implementation of the resource-path injector does not support 
> multiple values. I think it could be useful to inject a list of paths from 
> the valuemap.
>  I have created a small patch to allow this. Right now it only allows them 
> from the value map since I didn't want to change the API without consulting 
> you first. I you agree I can do this change as well. I also added a test case 
> for it.
> You can see a pull request in https://github.com/apache/sling/pull/51
> If there anything I can do to improve this patch, please let me know.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to