[
https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494037#comment-14494037
]
Felix Meschberger commented on SLING-4544:
------------------------------------------
Thanks for providing the patch. Yet it keeps hard references to the argument
objects which may keep those objects from being collected. As such I don't
think we should apply this patch. See discussion above. Thanks.
> Performance: MessageFormat shouldn't be used for logging in
> SlingRequestProgressTracker
> ---------------------------------------------------------------------------------------
>
> Key: SLING-4544
> URL: https://issues.apache.org/jira/browse/SLING-4544
> Project: Sling
> Issue Type: Improvement
> Components: Engine
> Affects Versions: Engine 2.4.0
> Reporter: Joel Richard
> Labels: performance
> Attachments: SLING-4544.patch, Screen Shot 2015-03-25 at 10.42.05.png
>
>
> I am profiling an application where 1-5% of the rendering time is spent in
> MessageFormat.format for SlingRequestProgressTracker.log (see attached
> screenshot). Since the advanced capabilities of MessageFormat are not
> required here, it should be rather easy to implement a utility which supports
> \{x} as well but is much faster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
