Hi guys, The sling-testing-tools [0] has become a container for different small pieces of code that don't fit in the other projects under testing/ [1]. What I have identified to be unrelated tools in there are:
* jarexec + serversetup * http clients * some junit tooling Valentin and I would like to contribute some patches with some code evolved from code based on the http and junit part of the sling-testing-tools. Could you please have a look at my fork [2] and review? For clients, the README [3] is quite revealing. The changes would be the following: * leave the tools/ (sling testing tools) untouched, with the idea to eventually deprecate it if the other modules fit the needs. * create a new module, called serversetup with the jarexec and serversetup packages copied from sling-testing-tools. * create module http/clients with some stuff like the WebconsoleClient copied from tools/ and a bunch of classes that replace the RequestExecutor and client with Threadsafe, well-tested and HttpClient-compatible http tooling. * create module http/rules with junit tooling dependent on the clients which follow the more modern approach to junit rules rather than test base classes and provide ootb rules with clients, junit filtering, configuring references to available sling instances, etc. Both this and clients are designed with extendability in mind. I checked and the tools module is not that well-maintained, neither is it referenced in too many tests. Additionally, I volunteer to cleanup and maintain some of the sling tests running over http against one or more sling instances, if needed. Looking forward to your thoughts. Cheers, - Andrei --- [0] https://github.com/apache/sling/tree/trunk/testing/tools/src/main/java/org/apache/sling/testing/tools [1] https://github.com/apache/sling/tree/trunk/testing [2] https://github.com/dulvac/sling/tree/sling-testing-tools/testing [3] https://github.com/dulvac/sling/blob/sling-testing-tools/testing/http/clients/README.md
