Hi Bertrand, I think it was a problem from before, when you build the local module first and then from the testing/ reactor. I fixed it by adding a clean plugin configuration and a rat plugin configuration to the reactor pom.
Also, I moved TimeoutsProvider to its own java package. You can find the PR at: https://github.com/apache/sling/pull/136 JIRA issue: https://issues.apache.org/jira/browse/SLING-5703 Thanks for all the help and the interest. - Andrei On Fri, Apr 29, 2016 at 11:53 AM Bertrand Delacretaz <bdelacre...@apache.org> wrote: > Hi Andrei, > > On Fri, Apr 29, 2016 at 10:00 AM, Andrei Dulvac <andrei.dul...@gmail.com> > wrote: > > ...I took your comments and adapted the two modules, as well as changed > the > > samples tests module to use the new clients and rules.... > > Ok thanks! > > I think the http/clients and junit/rules modules are good now apart > from the build issue mentioned in my last message here. > > I agree that the samples/bundle-with-it tests look cleaner with your > variants of the HTTP clients. > > I think TimeoutsProvider would be better in its own > o.a.s.testing.timeouts package. in case we want to split it out later. > > Apart from that IMO you're good to create a jira ticket and patches for > this. > > -Bertrand >
