[
https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125268#comment-16125268
]
Chetan Mehrotra commented on SLING-7043:
----------------------------------------
bq. it's now depending on two APIs (Slings metrics and Dropwizard).
Okie. So far in none of other places the code had to depend on MetricRegistry.
If the code want to use that then yes it need not go over abstraction provided
by Common Metrics.
We discussed all this when metrics abstraction was introduced (see DL threads
referred in SLING-4080). If you think most code need to use MetricRegistry also
then its fine to drop Commons Metrics
> Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction
> --------------------------------------------------------------------------
>
> Key: SLING-7043
> URL: https://issues.apache.org/jira/browse/SLING-7043
> Project: Sling
> Issue Type: Bug
> Affects Versions: Commons Metrics 1.0.0
> Reporter: Carsten Ziegeler
> Priority: Blocker
> Fix For: commons metrics 1.2.4
>
>
> commons metrics provides a nice abstraction over com.codahale.metrics -
> however it is exporting com.codahale.metrics.MetricRegistry which seems to
> be the only way to get at registered metrics objects. Which in turn is
> completely breaking the purpose of this bundle.
> So we should
> a) drop exporting that service and avoid leaking internal implementation
> details
> b) create our own version of the registry service
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
