[
https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125302#comment-16125302
]
Carsten Ziegeler commented on SLING-7043:
-----------------------------------------
I understand the "intend" of our own abstraction - but again it is totally
flawed as we expose a way to get to the underlying implementation as an API
contract. This gives a false sense of safety.
Either we have a full abstraction making it safe to use - or we don't need the
abstraction. But this is now something in the middle saying "yeah we have this
abstraction, but you can directly use the dropwizard api as well" - and not
even that for some use cases you have to use the dropwizard api as commons
scheduler shows
> Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction
> --------------------------------------------------------------------------
>
> Key: SLING-7043
> URL: https://issues.apache.org/jira/browse/SLING-7043
> Project: Sling
> Issue Type: Bug
> Affects Versions: Commons Metrics 1.0.0
> Reporter: Carsten Ziegeler
> Priority: Blocker
> Fix For: commons metrics 1.2.4
>
>
> commons metrics provides a nice abstraction over com.codahale.metrics -
> however it is exporting com.codahale.metrics.MetricRegistry which seems to
> be the only way to get at registered metrics objects. Which in turn is
> completely breaking the purpose of this bundle.
> So we should
> a) drop exporting that service and avoid leaking internal implementation
> details
> b) create our own version of the registry service
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
