Hi Konrad,

On Sat, 2017-09-02 at 10:38 +0200, Konrad Windszus wrote:
> Sorry for answering late, but wouldn't the buildhelper plugin with
> its parse-version fulfill our needs: http://www.mojohaus.org/build-he
> lper-maven-plugin/parse-version-mojo.html
> 
> That should be able to generate all version strings in the required
> formats from one source property.

The functionality is not about setting the project's version, but about
generating the 'minimum supported java' version for various plugins.
For javac and animal-sniffer it's usually the Java version number. For
the maven-bundle-plugin it's the Bundle-RequiredExecutionEnvironment
header.

I don't see how the build helper plugin can generate the Bundle-
RequiredExecutionEnvironment header. Is there such an option?

Thanks,

Robert

> 
> Von meinem iPhone gesendet
> 
> > Am 01.09.2017 um 10:10 schrieb Karl Pauls <karlpa...@gmail.com>:
> > 
> > +1
> > 
> > regards,
> > 
> > Karl
> > 
> > > On Fri, Sep 1, 2017 at 8:35 AM, Carsten Ziegeler <cziegeler@apach
> > > e.org> wrote:
> > > Sounds good to me, thanks Robert
> > > 
> > > Carsten
> > > 
> > > Robert Munteanu wrote
> > > > Hi,
> > > > 
> > > > As you might know, running the Sling ITs with Java 9 is blocked
> > > > by an
> > > > incompatibility of the maven-antrun-plugin with Java 9 ([1],
> > > > [2]).
> > > > 
> > > > It seems that a solution is not yet agreed on and I'd like to
> > > > start
> > > > running the ITs on Java 9 sooner rather than later.
> > > > 
> > > > To that end, I've written a tiny Maven plugin which does
> > > > exactly what
> > > > the maven-antrun-plugin snippet did [3]. TBH, I never really
> > > > liked
> > > > scripting in the pom but that's another issue :-)
> > > > 
> > > > Anyway, my proposal is to drop the maven-antrun-plugin _only_
> > > > for
> > > > setting the project properties in the parent pom. Bertrand
> > > > rightly
> > > > mentioned that we have other usages all over Sling, but those
> > > > do not
> > > > affect running the ITs and I won't touch them.
> > > > 
> > > > Thoughts?
> > > > 
> > > > Robert
> > > > 
> > > > [1]: https://issues.apache.org/jira/browse/SLING-7072
> > > > [2]: https://issues.apache.org/jira/browse/MNG-6275
> > > > [3]: http://svn.apache.org/viewvc?rev=1806875&view=rev
> > > > 
> > > 
> > > 
> > > 
> > > 
> > > --
> > > Carsten Ziegeler
> > > Adobe Research Switzerland
> > > cziege...@apache.org
> > 
> > 
> > 
> > -- 
> > Karl Pauls
> > karlpa...@gmail.com

Reply via email to