[
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532867#comment-16532867
]
Nicolas Peltier commented on SLING-7759:
----------------------------------------
that's great [~jsedding]!
i didn't like it neither, comes out of a strange re-absorption of java 8 code
in java 7, and your version is much better.
- The only thing bugging me here is that we'll test over & over presence of a
given configuration, even if we know from registration it is (or not) here,
will think about a way to have best of both worlds,
- How do i do with your commit? should i merge it, and redo a commit, or should
i amend my initial commit (losing your name), problem with the later that seems
the better to me is that we'll end up with 3 commits and we might only need one?
> add other "patterns" than path for filters
> ------------------------------------------
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
> Affects Versions: Engine 2.6.12
> Reporter: Nicolas Peltier
> Assignee: Nicolas Peltier
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> adding additional patterns to filters (right now {{sling.filter.pattern}}
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add
> sling.filter.pattern.path for consistency with what follow) regexp matches
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
