[ 
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533879#comment-16533879
 ] 

Konrad Windszus commented on SLING-7759:
----------------------------------------

I would go for extending the {{SlingServletFilter}}. All properties somehow 
have the same purpose of restricting where the filter may be executed and we 
should make people aware of all the different filtering possibilities. That is 
easier with one annotation. I don't see a good reason to split this up in this 
case (because the new properties are only useful in the context of a servlet 
filter and may all be combined).

> add other "patterns" than path for filters
> ------------------------------------------
>
>                 Key: SLING-7759
>                 URL: https://issues.apache.org/jira/browse/SLING-7759
>             Project: Sling
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: Engine 2.6.12
>            Reporter: Nicolas Peltier
>            Assignee: Nicolas Peltier
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> adding additional patterns to filters (right now {{sling.filter.pattern}} 
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy &  add 
> sling.filter.pattern.path for consistency with what follow) regexp matches 
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix  passes if sling.filter.pattern.suffix regep matches current suffix



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to