On 2018-07-08 14:34, Stefan Seifert wrote:
i would also favor switchting to the findbugs nullable annotations (now
repackaged and maintained as spotbugs annotations).
AFAIU, we can't due to the license (LGPL).
we should remove the jsr 305 dependency from our parent pom, and probably add
instead:
<dependency>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-annotations</artifactId>
<version>3.1.5</version>
<scope>provided</scope>
<exclusions>
<exclusion>
<groupId>com.google.code.findbugs</groupId>
<artifactId>jsr305</artifactId>
</exclusion>
</exclusions>
</dependency>
in recent eclipse versions it's possible to configure multiple
nullable-annotations - so it's possible to support both the javax.annotation
and the findbugs annotations - making it easy working with already released
sling artifacts still using the javax.annotation annotations. on the long run
we should migrate away from those.
and we have to update [1] then. not we sure if we still need to support only
"CheckForNull" - it would be nice to also support "Nullable" (in eclipse it's
possible to configure both). the related jackrabbit ticket is [2].
...
See also <https://issues.apache.org/jira/browse/JCR-4301> which for now
has been resolved by switching to the Jetbrains annotations.
Best regards, Julian
