Would someone mind taking a look at the last commit and ensure I'm using the Provider / Consumer Type annotations correctly?
https://github.com/apache/sling-org-apache-sling-file-optimization/commit/b8abe02a3e4290743cb89a5f8a4a077ec884be69 Thanks! On Thu, Sep 6, 2018 at 11:59 AM Daniel Klco <dk...@apache.org> wrote: > Thanks for spotting this Jason. I'm going to cancel this release and > resolve the issues. > > Regards, > Dan > > On Thu, Sep 6, 2018 at 11:17 AM Jason E Bailey <j...@apache.org> wrote: > >> Hey Dan, >> >> Since the interfaces that are made available are meant to be provided by >> the bundle they should be annotated with the @ProviderType annotation. >> >> Additionally, the default style for Sling is that spaces are used for >> indentations rather than tabs. Just an FYI. >> >> - Jason >> >> On Thu, Sep 6, 2018, at 11:06 AM, Daniel Klco wrote: >> > +1 >> > >> > On Thu, Sep 6, 2018 at 11:01 AM Daniel Klco <dk...@apache.org> wrote: >> > >> > > Hi, >> > > >> > > We solved 1 issues in this release: >> > > https://issues.apache.org/jira/projects/SLING/versions/12343855 >> > > >> > > Staging repository: >> > > >> https://repository.apache.org/content/repositories/orgapachesling-1957/ >> > > >> > > You can use this UNIX script to download the release and verify the >> > > signatures: >> > > >> > > >> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD >> > > >> > > Usage: >> > > sh check_staged_release.sh 1957 /tmp/sling-staging >> > > >> > > Please vote to approve this release: >> > > >> > > [ ] +1 Approve the release >> > > [ ] 0 Don't care >> > > [ ] -1 Don't release, because ... >> > > >> > > This majority vote is open for at least 72 hours. >> > > >> >
