[ 
https://issues.apache.org/jira/browse/SLING-8042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656741#comment-16656741
 ] 

Robert Munteanu commented on SLING-8042:
----------------------------------------

I might be missing something, but declaring the id looks like it's not needed.

I assume we need the id only to reference a feature from other features. 
Inferring from the file name is fine for me, and I guess the Maven plugin can 
augment the feature with all the groupId/artifactId/version/etc information 
automatically.

The only reason for manually setting the id is when this logic fails. I don't 
see a good scenario right now. The only one I can think of is renaming the 
feature or changing Maven coordinates and wanting to keep the same coordinates 
for backwards compatibility. But I don't think this is really needed, even if 
possible from a Maven POV.

> The slingfeature-maven-plugin should be able to derive the name of a feature 
> from the file name
> -----------------------------------------------------------------------------------------------
>
>                 Key: SLING-8042
>                 URL: https://issues.apache.org/jira/browse/SLING-8042
>             Project: Sling
>          Issue Type: Improvement
>          Components: Feature Model
>            Reporter: Radu Cotescu
>            Assignee: David Bosschaert
>            Priority: Major
>
> The {{slingfeature-maven-plugin}} should be able to derive the name of a 
> feature from the file name, if the name is missing from the feature 
> definition.
> Assuming a file called {{my-feature.json}}, with the following contents:
> {noformat}
> {
>     "id" : 
> "${project.groupId}:${project.artifactId}:slingfeature:${project.version}",
>     "bundles" :[
>        ...
>     ]
> }
> {noformat}
> then the {{slingfeature-maven-plugin}} should infer that the feature it's 
> building is called {{my-feature}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to