[ 
https://issues.apache.org/jira/browse/SLING-8042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656759#comment-16656759
 ] 

Karl Pauls commented on SLING-8042:
-----------------------------------

Well, I guess the argument was that you might want to be able to work with 
features without requiring maven to build them - hence, the possibility to 
specify an id. Furthermore, it is somewhat easy to see the context when you 
look at the file in isolation. I personally think that is fine but it seems 
like it is overkill in the cases where they are part of a maven build. Can't we 
make it so that:

* features need an id
* features in a maven build don't have an id but get them set during the build 
with their file name as classifier

In other words, when you look at a feature in a maven repo, it will have an id 
but if you look at the src dir it will not and the maven plugin will always 
just set the correct id based on the groupid/artifactid/version/classifier. 
Wouldn't that be a reasonable compromise?

> The slingfeature-maven-plugin should be able to derive the name of a feature 
> from the file name
> -----------------------------------------------------------------------------------------------
>
>                 Key: SLING-8042
>                 URL: https://issues.apache.org/jira/browse/SLING-8042
>             Project: Sling
>          Issue Type: Improvement
>          Components: Feature Model
>            Reporter: Radu Cotescu
>            Assignee: David Bosschaert
>            Priority: Major
>
> The {{slingfeature-maven-plugin}} should be able to derive the name of a 
> feature from the file name, if the name is missing from the feature 
> definition.
> Assuming a file called {{my-feature.json}}, with the following contents:
> {noformat}
> {
>     "id" : 
> "${project.groupId}:${project.artifactId}:slingfeature:${project.version}",
>     "bundles" :[
>        ...
>     ]
> }
> {noformat}
> then the {{slingfeature-maven-plugin}} should infer that the feature it's 
> building is called {{my-feature}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to