Since this does not seem to affect all cases where the IntelliJ null annotations are used I would recommend we enforce building with Java 9+ only for the Sling API part for Mac OS X for now. We can extend to other operating systems if this reliably fails for them as well. WDYT?
> On 18. Dec 2018, at 17:35, Konrad Windszus <konra...@gmx.de> wrote: > > We can still put it in a dedicated profile which is only active on a Mac. > I would volunteer to add it to the parent pom since a lot of modules are > affected (as the IntelliJ Null annotations are used all over the place). > > Konrad > >> On 18. Dec 2018, at 17:03, Robert Munteanu <romb...@apache.org> wrote: >> >> It's worth noting that it only affects Mac builds so far, so enforcing >> Java 9 might be a step too far. >> >> Robert >> >> On Tue, 2018-12-18 at 17:01 +0100, Konrad Windszus wrote: >>> I think due to that we should enforce building with at least Java 9. >>> WDYT? >>> >>>> On 18. Dec 2018, at 16:54, Konrad Windszus <konra...@gmx.de> wrote: >>>> >>>> Thanks a lot for that. Observed that as well but haven't had the >>>> time to investigate. I fear though that Oracle will no longer fix >>>> stuff in JDK 8. >>>> Konrad >>>> >>>>> On 18. Dec 2018, at 16:51, Radu Cotescu <r...@apache.org> wrote: >>>>> >>>>> Hi, >>>>> >>>>> I’ve submitted yesterday this bug [0] to Oracle. TL;DR: one >>>>> cannot build the org.apache.sling.api JavaDocs with JDK 8 on >>>>> macOS. It all started with [1], but it’s obviously a JDK bug. >>>>> >>>>> Cheers, >>>>> Radu >>>>> >>>>> [0] - >>>>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542 >>>>> <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK- >>>>> 8215542> >>>>> [1] - >>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6 >>>>> < >>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6 >>>>>> >>>>> >> >> >
