Tried to do this with 
https://github.com/apache/sling-org-apache-sling-api/commit/63caf8de12b6187698a2f0f1ed2225f8315e9ce4
 
<https://github.com/apache/sling-org-apache-sling-api/commit/63caf8de12b6187698a2f0f1ed2225f8315e9ce4>.
Unfortunately the seed job does not seem to pick that up: 
https://builds.apache.org/view/S-Z/view/Sling/job/sling-seed-build/168/console 
<https://builds.apache.org/view/S-Z/view/Sling/job/sling-seed-build/168/console>

I don't even find the entry in the build log for org-apache-sling-api.
This seems to be due to the fact that entry additionalMavenParams is documented 
in https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor 
<https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor> but 
not evaluated in 
https://github.com/apache/sling-tooling-jenkins/blob/master/create_jobs.groovy 
<https://github.com/apache/sling-tooling-jenkins/blob/master/create_jobs.groovy>.

@Robert: Since this is a pretty central piece I don't really dare to do changes 
here but to me it seems that the variable "module.extraGoalsParams" is never 
set by anyone. WDYT?

Thanks,
Konrad





> On 7. Jan 2019, at 13:27, Radu Cotescu <r...@apache.org> wrote:
> 
> Hi Konrad,
> 
>> On 7 Jan 2019, at 11:40, Konrad Windszus <konra...@gmx.de> wrote:
>> 
>> or should I create a .sling-module.xml for the API module setting an 
>> explicit property via <additionalMavenParams>
> 
> I find this approach cleaner and easier to document - setting 
> maven.javadoc.skip to true sounds nicer than a check for a JENKINS_* 
> environment variable.
> 
> Thanks,
> Radu

Reply via email to