rmcdouga commented on a change in pull request #6: Added support for simulating
HTML forms (including file uploads)…
URL:
https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/6#discussion_r288193058
##########
File path:
src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequest.java
##########
@@ -516,6 +529,36 @@ public RequestParameterMap getRequestParameterMap() {
return params;
}
+ public void addRequestParameter(String name, String value) {
+ if (this.parameterMap.containsKey(name)) {
Review comment:
I've changed the settings in my IDE (Eclipse) and reformatted the whole
file. This has caused some incidental changes (putting spaces after commas,
etc.) that I think are positive so I have left them in. The only thing that
might be an issue is that my line wrapping is at 180 chars. A couple of lines
that were previously split are now merged to one line. Is that a problem? I
assume there is a style guide somewhere. If you could point me to it, I will
set my formatting settings appropriately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
