rmcdouga commented on a change in pull request #6: Added support for simulating 
HTML forms (including file uploads)…
URL: 
https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/6#discussion_r288789685
 
 

 ##########
 File path: 
src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequest.java
 ##########
 @@ -516,6 +529,36 @@ public RequestParameterMap getRequestParameterMap() {
         return params;
     }
 
+    public void addRequestParameter(String name, String value) {
+       if (this.parameterMap.containsKey(name)) {
 
 Review comment:
   >  just make sure to make a separate commit for reformatting
   
   Sorry, I already checked in commit that has the reformatting mixed.  I think 
it's OK however.  The changes weren't that extensive (tabs to spaces, longer 
lines in 2 cases, and single spaces inserted in a few places - such as after 
commas and between for and open parenthesis). 
   
   Have a look at my latest commit.  If you are concerned I can back it out and 
separate out the reformatting.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to