+1 On Wed, Apr 15, 2020 at 9:57 AM Carsten Ziegeler <[email protected]> wrote:
> Thanks, I created https://issues.apache.org/jira/browse/SLING-9375 for > tracking > > Carsten > > On 15.04.2020 15:23, Stefan Seifert wrote: > > ok, here is my +1 > > > > validated signatures and validated the ITs in a linux VM, they run fine > there > > > > stefan > > > >> -----Original Message----- > >> From: Carsten Ziegeler <[email protected]> > >> Sent: Wednesday, April 15, 2020 3:06 PM > >> To: [email protected] > >> Subject: Re: [VOTE] Release Apache Sling Slingfeature Maven Plugin 1.2.0 > >> > >> Confirmed, 1.2.0 fails the apis-jar test on windows for me as well. I > >> think we should tackle this after the 1.2.0 release (as other things > >> where failing before in windows as well) > >> > >> Carsten > >> > >> On 15.04.2020 14:06, Stefan Seifert wrote: > >>> yes, only "apis-jar" fails with version 1.2.0 > >>> > >>> i've tested a the previous releases (e.g. 1.1.20) - in this version > >> "apis-jar" runs fine - but instead the IT "apis-jar-exported-package-no- > >> classes" fails (which runs fine in 1.2.0). > >>> > >>> probably a windows-specific problem? i've not tested on another OS yet. > >>> > >>> stefan > >>> > >>>> -----Original Message----- > >>>> From: Carsten Ziegeler <[email protected]> > >>>> Sent: Wednesday, April 15, 2020 11:45 AM > >>>> To: [email protected] > >>>> Subject: Re: [VOTE] Release Apache Sling Slingfeature Maven Plugin > 1.2.0 > >>>> > >>>> It builds for me and tests run fine, both with 8 and 11 - is that the > >>>> only failing test case? Did older releases work for you? > >>>> > >>>> Regards > >>>> Carsten > >>>> > >>>> On 15.04.2020 11:27, Stefan Seifert wrote: > >>>>> if i build the project locally the integration test "apis-jar" fails > >> with > >>>> this error (tested with java 8 and java 11): > >>>>> > >>>>> > >>>>> [INFO] Building jar: D:\Develop\OpenSource\sling-git\sling- > >> slingfeature- > >>>> maven-plugin\target\it\apis-jar\target\apis-jars\slingfeature-maven- > >> plugin- > >>>> test-1.0.0-SNAPSHOT-base-apis.jar > >>>>> [INFO] Verified apis jar for region base > >>>>> [DEBUG] Adding directory org.apache.felix.inventory-1.0.6.jar with > >>>> [org/apache/felix/inventory/*] > >>>>> [DEBUG] Adding directory org.apache.felix.metatype-1.2.2.jar with > >>>> [org/apache/felix/metatype/*] > >>>>> [INFO] Building jar: D:\Develop\OpenSource\sling-git\sling- > >> slingfeature- > >>>> maven-plugin\target\it\apis-jar\target\apis-jars\slingfeature-maven- > >> plugin- > >>>> test-1.0.0-SNAPSHOT-base-sources.jar > >>>>> [INFO] Verified sources jar for region base > >>>>> [INFO] Executing javadoc tool: [C:\java\jdk-11.0.2\bin\javadoc.exe, > >>>> @D:\Develop\OpenSource\sling-git\sling-slingfeature-maven- > >>>> plugin\target\it\apis-jar\target\apis-jars\slingfeature-maven-plugin- > >>>> test\base\base-javadoc] > >>>>> [INFO] > >>>>> Loading source files for package org.apache.felix.metatype... > >>>>> javadoc: error - No source files for package > org.apache.felix.metatype > >>>>> 1 error > >>>>> [INFO] > ---------------------------------------------------------------- > >> -- > >>>> ------ > >>>>> [INFO] BUILD FAILURE > >>>>> [INFO] > ---------------------------------------------------------------- > >> -- > >>>> ------ > >>>>> [INFO] Total time: 4.926 s > >>>>> [INFO] Finished at: 2020-04-15T11:24:57+02:00 > >>>>> [INFO] > ---------------------------------------------------------------- > >> -- > >>>> ------ > >>>>> [ERROR] Failed to execute goal org.apache.sling:slingfeature-maven- > >>>> plugin:1.2.1-SNAPSHOT:apis-jar (default-cli) on project slingfeature- > >> maven- > >>>> plugin-test: Javadoc generation failed. See log for more details. > >> Process > >>>> exited with an error: 2 (Exit value: 2) -> [Help 1] > >>>>> > >>>>> > >>>>> stefan > >>>>> > >>>>> > >>>>>> -----Original Message----- > >>>>>> From: Carsten Ziegeler <[email protected]> > >>>>>> Sent: Wednesday, April 15, 2020 9:52 AM > >>>>>> To: [email protected] > >>>>>> Subject: [VOTE] Release Apache Sling Slingfeature Maven Plugin 1.2.0 > >>>>>> > >>>>>> Hi, > >>>>>> > >>>>>> we solved 7 issues in this release > >>>>>> > >>>>>> https://issues.apache.org/jira/projects/SLING/versions/12347874 > >>>>>> > >>>>>> Staging repository: > >>>>>> > https://repository.apache.org/content/repositories/orgapachesling-2240 > >>>>>> > >>>>>> You can use this UNIX script to download the release and verify the > >>>>>> signatures: > >>>>>> https://gitbox.apache.org/repos/asf?p=sling-tooling- > >>>>>> release.git;a=blob;f=check_staged_release.sh;hb=HEAD > >>>>>> > >>>>>> Usage: > >>>>>> sh check_staged_release.sh 2240 /tmp/sling-staging > >>>>>> > >>>>>> Please vote to approve this release: > >>>>>> > >>>>>> [ ] +1 Approve the release > >>>>>> [ ] 0 Don't care > >>>>>> [ ] -1 Don't release, because ... > >>>>>> > >>>>>> This majority vote is open for at least 72 hours. > >>>>>> > >>>>>> Regards > >>>>>> Carsten > >>>>>> -- > >>>>>> Carsten Ziegeler > >>>>>> Adobe Research Switzerland > >>>>>> [email protected] > >>>>> > >>>> > >>>> -- > >>>> -- > >>>> Carsten Ziegeler > >>>> Adobe Research Switzerland > >>>> [email protected] > >>> > >> > >> -- > >> -- > >> Carsten Ziegeler > >> Adobe Research Switzerland > >> [email protected] > > > > -- > -- > Carsten Ziegeler > Adobe Research Switzerland > [email protected] >
