saurabh-khare commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-superimposing/pull/1#discussion_r429749856
##########
File path: pom.xml
##########
@@ -43,77 +42,203 @@
<build>
<plugins>
-
+ <!-- Maven Enforcer Plugin -->
<plugin>
- <groupId>org.apache.felix</groupId>
- <artifactId>maven-scr-plugin</artifactId>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-maven</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <requireMavenVersion>
+ <version>[3.5.4,)</version>
+ </requireMavenVersion>
+ <requireJavaVersion>
+ <message>Project must be compiled with
Java 8 or higher</message>
+ <version>1.8.0</version>
+ </requireJavaVersion>
+ </rules>
+ </configuration>
+ </execution>
+ </executions>
</plugin>
-
+ <!-- Maven Compiler Plugin -->
<plugin>
- <groupId>org.apache.felix</groupId>
- <artifactId>maven-bundle-plugin</artifactId>
- <extensions>true</extensions>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
<configuration>
- <instructions>
-
<Export-Package>org.apache.sling.superimposing</Export-Package>
-
<Private-Package>org.apache.sling.superimposing.impl</Private-Package>
-
<DynamicImport-Package>org.apache.felix.webconsole</DynamicImport-Package>
-
<Sling-Nodetypes>SLING-INF/nodetypes/superimposing.cnd</Sling-Nodetypes>
- </instructions>
+ <source>1.8</source>
+ <target>1.8</target>
</configuration>
</plugin>
-
+ <!-- Maven IntelliJ IDEA Plugin -->
+ <plugin>
Review comment:
Removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
