saurabh-khare commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-superimposing/pull/1#discussion_r429750172
##########
File path: pom.xml
##########
@@ -43,77 +42,203 @@
<build>
<plugins>
-
+ <!-- Maven Enforcer Plugin -->
<plugin>
- <groupId>org.apache.felix</groupId>
- <artifactId>maven-scr-plugin</artifactId>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-maven</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <requireMavenVersion>
+ <version>[3.5.4,)</version>
+ </requireMavenVersion>
+ <requireJavaVersion>
+ <message>Project must be compiled with
Java 8 or higher</message>
+ <version>1.8.0</version>
+ </requireJavaVersion>
+ </rules>
+ </configuration>
+ </execution>
+ </executions>
</plugin>
-
+ <!-- Maven Compiler Plugin -->
<plugin>
- <groupId>org.apache.felix</groupId>
- <artifactId>maven-bundle-plugin</artifactId>
- <extensions>true</extensions>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
<configuration>
- <instructions>
-
<Export-Package>org.apache.sling.superimposing</Export-Package>
-
<Private-Package>org.apache.sling.superimposing.impl</Private-Package>
-
<DynamicImport-Package>org.apache.felix.webconsole</DynamicImport-Package>
-
<Sling-Nodetypes>SLING-INF/nodetypes/superimposing.cnd</Sling-Nodetypes>
- </instructions>
+ <source>1.8</source>
+ <target>1.8</target>
</configuration>
</plugin>
-
+ <!-- Maven IntelliJ IDEA Plugin -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-idea-plugin</artifactId>
+ <version>2.2.1</version>
+ <configuration>
+ <jdkLevel>1.8</jdkLevel>
+ <linkModules>true</linkModules>
+ <downloadSources>true</downloadSources>
+ </configuration>
+ </plugin>
+ <!-- Maven Eclipse Plugin -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-eclipse-plugin</artifactId>
+ <version>2.10</version>
+ <configuration>
+ <downloadSources>true</downloadSources>
+ </configuration>
+ </plugin>
+ <!-- Maven Clean Plugin -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-clean-plugin</artifactId>
+ <version>3.0.0</version>
+ </plugin>
+ <!-- Maven Sling Plugin -->
<plugin>
<groupId>org.apache.sling</groupId>
<artifactId>maven-sling-plugin</artifactId>
+ <version>2.3.8</version>
+ </plugin>
+ <!-- BND Maven Plugin -->
+ <plugin>
+ <groupId>biz.aQute.bnd</groupId>
+ <artifactId>bnd-maven-plugin</artifactId>
+ <version>5.0.1</version>
+ <executions>
+ <execution>
+ <id>bnd-process</id>
+ <goals>
+ <goal>bnd-process</goal>
+ </goals>
+ <configuration>
+ <bnd>
+ Export-Package: org.apache.sling.superimposing
+ Private-Package:
org.apache.sling.superimposing.impl
+ DynamicImport-Package:
org.apache.felix.webconsole
+ Sling-Nodetypes:
SLING-INF/nodetypes/superimposing.cnd
+ </bnd>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>biz.aQute.bnd</groupId>
+ <artifactId>bnd-baseline-maven-plugin</artifactId>
+ <version>5.0.1</version>
+ <configuration>
+ <failOnMissing>false</failOnMissing>
+ </configuration>
+ <executions>
Review comment:
Removed
##########
File path: pom.xml
##########
@@ -43,77 +42,203 @@
<build>
<plugins>
-
+ <!-- Maven Enforcer Plugin -->
<plugin>
- <groupId>org.apache.felix</groupId>
- <artifactId>maven-scr-plugin</artifactId>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-maven</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <requireMavenVersion>
+ <version>[3.5.4,)</version>
+ </requireMavenVersion>
+ <requireJavaVersion>
+ <message>Project must be compiled with
Java 8 or higher</message>
+ <version>1.8.0</version>
+ </requireJavaVersion>
+ </rules>
+ </configuration>
+ </execution>
+ </executions>
</plugin>
-
+ <!-- Maven Compiler Plugin -->
<plugin>
- <groupId>org.apache.felix</groupId>
- <artifactId>maven-bundle-plugin</artifactId>
- <extensions>true</extensions>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
<configuration>
- <instructions>
-
<Export-Package>org.apache.sling.superimposing</Export-Package>
-
<Private-Package>org.apache.sling.superimposing.impl</Private-Package>
-
<DynamicImport-Package>org.apache.felix.webconsole</DynamicImport-Package>
-
<Sling-Nodetypes>SLING-INF/nodetypes/superimposing.cnd</Sling-Nodetypes>
- </instructions>
+ <source>1.8</source>
+ <target>1.8</target>
</configuration>
</plugin>
-
+ <!-- Maven IntelliJ IDEA Plugin -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-idea-plugin</artifactId>
+ <version>2.2.1</version>
+ <configuration>
+ <jdkLevel>1.8</jdkLevel>
+ <linkModules>true</linkModules>
+ <downloadSources>true</downloadSources>
+ </configuration>
+ </plugin>
+ <!-- Maven Eclipse Plugin -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-eclipse-plugin</artifactId>
+ <version>2.10</version>
+ <configuration>
+ <downloadSources>true</downloadSources>
+ </configuration>
+ </plugin>
+ <!-- Maven Clean Plugin -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-clean-plugin</artifactId>
+ <version>3.0.0</version>
+ </plugin>
+ <!-- Maven Sling Plugin -->
<plugin>
<groupId>org.apache.sling</groupId>
<artifactId>maven-sling-plugin</artifactId>
+ <version>2.3.8</version>
+ </plugin>
+ <!-- BND Maven Plugin -->
+ <plugin>
+ <groupId>biz.aQute.bnd</groupId>
+ <artifactId>bnd-maven-plugin</artifactId>
+ <version>5.0.1</version>
+ <executions>
+ <execution>
+ <id>bnd-process</id>
+ <goals>
+ <goal>bnd-process</goal>
+ </goals>
+ <configuration>
+ <bnd>
+ Export-Package: org.apache.sling.superimposing
+ Private-Package:
org.apache.sling.superimposing.impl
+ DynamicImport-Package:
org.apache.felix.webconsole
+ Sling-Nodetypes:
SLING-INF/nodetypes/superimposing.cnd
+ </bnd>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>biz.aQute.bnd</groupId>
+ <artifactId>bnd-baseline-maven-plugin</artifactId>
+ <version>5.0.1</version>
+ <configuration>
+ <failOnMissing>false</failOnMissing>
+ </configuration>
+ <executions>
+ <execution>
+ <id>baseline</id>
+ <goals>
+ <goal>baseline</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ <!-- Maven Resources Plugin -->
+ <plugin>
Review comment:
Removed
##########
File path: pom.xml
##########
@@ -43,77 +42,203 @@
<build>
<plugins>
-
+ <!-- Maven Enforcer Plugin -->
<plugin>
- <groupId>org.apache.felix</groupId>
- <artifactId>maven-scr-plugin</artifactId>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-maven</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <requireMavenVersion>
+ <version>[3.5.4,)</version>
+ </requireMavenVersion>
+ <requireJavaVersion>
+ <message>Project must be compiled with
Java 8 or higher</message>
+ <version>1.8.0</version>
+ </requireJavaVersion>
+ </rules>
+ </configuration>
+ </execution>
+ </executions>
</plugin>
-
+ <!-- Maven Compiler Plugin -->
<plugin>
- <groupId>org.apache.felix</groupId>
- <artifactId>maven-bundle-plugin</artifactId>
- <extensions>true</extensions>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
<configuration>
- <instructions>
-
<Export-Package>org.apache.sling.superimposing</Export-Package>
-
<Private-Package>org.apache.sling.superimposing.impl</Private-Package>
-
<DynamicImport-Package>org.apache.felix.webconsole</DynamicImport-Package>
-
<Sling-Nodetypes>SLING-INF/nodetypes/superimposing.cnd</Sling-Nodetypes>
- </instructions>
+ <source>1.8</source>
+ <target>1.8</target>
</configuration>
</plugin>
-
+ <!-- Maven IntelliJ IDEA Plugin -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-idea-plugin</artifactId>
+ <version>2.2.1</version>
+ <configuration>
+ <jdkLevel>1.8</jdkLevel>
+ <linkModules>true</linkModules>
+ <downloadSources>true</downloadSources>
+ </configuration>
+ </plugin>
+ <!-- Maven Eclipse Plugin -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-eclipse-plugin</artifactId>
+ <version>2.10</version>
+ <configuration>
+ <downloadSources>true</downloadSources>
+ </configuration>
+ </plugin>
+ <!-- Maven Clean Plugin -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-clean-plugin</artifactId>
+ <version>3.0.0</version>
+ </plugin>
+ <!-- Maven Sling Plugin -->
<plugin>
<groupId>org.apache.sling</groupId>
<artifactId>maven-sling-plugin</artifactId>
+ <version>2.3.8</version>
+ </plugin>
+ <!-- BND Maven Plugin -->
+ <plugin>
+ <groupId>biz.aQute.bnd</groupId>
+ <artifactId>bnd-maven-plugin</artifactId>
+ <version>5.0.1</version>
+ <executions>
+ <execution>
+ <id>bnd-process</id>
+ <goals>
+ <goal>bnd-process</goal>
+ </goals>
+ <configuration>
+ <bnd>
+ Export-Package: org.apache.sling.superimposing
+ Private-Package:
org.apache.sling.superimposing.impl
+ DynamicImport-Package:
org.apache.felix.webconsole
+ Sling-Nodetypes:
SLING-INF/nodetypes/superimposing.cnd
+ </bnd>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>biz.aQute.bnd</groupId>
+ <artifactId>bnd-baseline-maven-plugin</artifactId>
+ <version>5.0.1</version>
+ <configuration>
+ <failOnMissing>false</failOnMissing>
+ </configuration>
+ <executions>
+ <execution>
+ <id>baseline</id>
+ <goals>
+ <goal>baseline</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ <!-- Maven Resources Plugin -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <version>3.0.2</version>
+ </plugin>
+ <!-- Maven Jar Plugin -->
+ <plugin>
Review comment:
Removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
