[ 
https://issues.apache.org/jira/browse/SLING-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224557#comment-17224557
 ] 

Stefan Seifert commented on SLING-9866:
---------------------------------------

do we have an urgent need to remove this feature? breaking it deliberately 
(with and empty stub) is not very polite, there may be thousands of projects 
out there currently relying on this validation (and not noticing that it's gone 
and shipping invalid JSON after that).

for sure that there may be better alternatives, but looking e.g. at 
[https://github.com/sylvainlaurent/yaml-json-validator-maven-plugin] it seems 
it has no incremental build support for eclipse.

> Remove Json validator
> ---------------------
>
>                 Key: SLING-9866
>                 URL: https://issues.apache.org/jira/browse/SLING-9866
>             Project: Sling
>          Issue Type: Improvement
>    Affects Versions: Sling Maven Plugin 2.4.2
>            Reporter: Konrad Windszus
>            Priority: Major
>             Fix For: Sling Maven Plugin 2.4.4
>
>
> In the context of SLING-653 a generic JSON file validator was added. This is 
> not Sling specific and there are specialized Maven plugins like 
> https://github.com/sylvainlaurent/yaml-json-validator-maven-plugin which do a 
> better job. I would recommend getting rid of 
> https://github.com/apache/sling-maven-plugin/blob/master/sling-maven-plugin/src/main/java/org/apache/sling/maven/bundlesupport/ValidationMojo.java
>  together with 
> https://github.com/apache/sling-maven-plugin/blob/master/sling-maven-plugin/src/main/java/org/apache/sling/maven/bundlesupport/JsonSupport.java
>  to reduce the footprint of the sling-maven-plugin.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to