[
https://issues.apache.org/jira/browse/SLING-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224562#comment-17224562
]
Konrad Windszus commented on SLING-9866:
----------------------------------------
bq. do we have an urgent need to remove this feature?
No, but looking at
https://sling.apache.org/components/maven-sling-plugin-archives/maven-sling-plugin-2.3.0/validate-mojo.html
it is not really clear what this mojo does (at least to me). Also it might
have an impact on build times as the way it iterates through all artifact
resources doesn't seem very effective with no way to skip certain folders....
in
https://github.com/apache/sling-maven-plugin/blob/ee08451c880cc8cdc554b4cf8964c35792d75326/sling-maven-plugin/src/main/java/org/apache/sling/maven/bundlesupport/ValidationMojo.java#L96
bq. and not noticing that it's gone and shipping invalid JSON after that
We can throw an exception in case it is still used so it won't be unnoticed. Do
you know of any projects using this feature?
> Remove Json validator
> ---------------------
>
> Key: SLING-9866
> URL: https://issues.apache.org/jira/browse/SLING-9866
> Project: Sling
> Issue Type: Improvement
> Affects Versions: Sling Maven Plugin 2.4.2
> Reporter: Konrad Windszus
> Priority: Major
> Fix For: Sling Maven Plugin 2.4.4
>
>
> In the context of SLING-653 a generic JSON file validator was added. This is
> not Sling specific and there are specialized Maven plugins like
> https://github.com/sylvainlaurent/yaml-json-validator-maven-plugin which do a
> better job. I would recommend getting rid of
> https://github.com/apache/sling-maven-plugin/blob/master/sling-maven-plugin/src/main/java/org/apache/sling/maven/bundlesupport/ValidationMojo.java
> together with
> https://github.com/apache/sling-maven-plugin/blob/master/sling-maven-plugin/src/main/java/org/apache/sling/maven/bundlesupport/JsonSupport.java
> to reduce the footprint of the sling-maven-plugin.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
