Hey all, I have a PR open that needs access to a new JAR library, so I've been trying to understand the full set of steps involved in adding a dependency to Solr. I followed the steps mentioned in `help/dependencies.txt` (i.e. 'gradlew helpDependencies') without too much trouble: the JAR is visible on the classpath and the 'solr/licenses/' directory has the appropriate checksum, license and NOTICE.txt files. Everything looks good.
Just when I thought I was done though, I noticed one more step in 'solr/licenses/README.committers.txt': > Under no circumstances should any new files be added to this directory > without careful consideration of how LICENSE.txt and NOTICE.txt in the > parent directory should be updated to reflect the addition. Does anyone remember the context around this step, and whether it is still valid today? It seems like it might be outdated, but maybe not. If appending to the top-level NOTICE.txt is still required: under what conditions? 'solr/NOTICE.txt' only has a NOTICE.txt file for ~40 dependencies: conspicuously few compared to the ~150 non empty NOTICE.txt files in the 'solr/licenses/' directory. Appreciate any context people can offer here: just looking to make sure I get the process right. Best, Jason --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org For additional commands, e-mail: dev-h...@solr.apache.org
