+1 (binding) Smoke tester passed + deployed to GKE with TLS / Basic Auth / ZK ACLs
Also verified running w/o installing the ZK CRD, using the Bitnami ZK Helm chart instead of the ZK operator, works great! Excellent work Houston! On Tue, Apr 27, 2021 at 9:52 AM Houston Putman <houstonput...@gmail.com> wrote: > > I tested this out and it's because clearing the go mod cache deletes the > dependencies for the build programs we have installed via "go install", which > includes go-license. > > If you delete go-license and controller-gen after clearing the cache, then > re-install dependencies, you should be good to go. > > > rm $GOPATH/bin/go-licenses && rm $GOPATH/bin/controller-gen && make > > install-dependencies > > make check-licenses > > - Houston > > > > > On Tue, Apr 27, 2021 at 3:22 AM Jan Høydahl <janhoy-apa...@cominvent.com> > wrote: >> >> I did brew uninstall go followed by brew install go, and re-ran the >> smoketester, but same issue. >> >> I tried a go clean -cache -modcache -i -r (from >> https://lecstor.com/go-clear-cache/) and I saw it pull lots of dependencies. >> But still error, this time much longer diff >> >> go-licenses csv . 2>/dev/null | grep -v -E "solr-operator" | sort | diff >> dependency_licenses.csv - >> 1,53d0 >> < cloud.google.com/go/compute/metadata,Unknown,Apache-2.0 >> < >> github.com/beorn7/perks/quantile,https://github.com/beorn7/perks/blob/master/quantile/LICENSE,MIT >> < >> github.com/cespare/xxhash/v2,https://github.com/cespare/xxhash/blob/master/v2/LICENSE.txt,MIT >> < >> github.com/davecgh/go-spew/spew,https://github.com/davecgh/go-spew/blob/master/spew/LICENSE,ISC >> < >> github.com/docker/spdystream,https://github.com/docker/spdystream/blob/master/LICENSE,Apache-2.0 >> < >> github.com/evanphx/json-patch,https://github.com/evanphx/json-patch/blob/master/LICENSE,BSD-3-Clause >> < >> github.com/fsnotify/fsnotify,https://github.com/fsnotify/fsnotify/blob/master/LICENSE,BSD-3-Clause >> < >> github.com/go-logr/logr,https://github.com/go-logr/logr/blob/master/LICENSE,Apache-2.0 >> < >> github.com/go-logr/zapr,https://github.com/go-logr/zapr/blob/master/LICENSE,Apache-2.0 >> < >> github.com/gogo/protobuf,https://github.com/gogo/protobuf/blob/master/LICENSE,BSD-3-Clause >> < >> github.com/golang/groupcache/lru,https://github.com/golang/groupcache/blob/master/lru/LICENSE,Apache-2.0 >> < >> github.com/golang/protobuf,https://github.com/golang/protobuf/blob/master/LICENSE,BSD-3-Clause >> < >> github.com/google/go-cmp/cmp,https://github.com/google/go-cmp/blob/master/cmp/LICENSE,BSD-3-Clause >> < >> github.com/google/gofuzz,https://github.com/google/gofuzz/blob/master/LICENSE,Apache-2.0 >> < >> github.com/google/uuid,https://github.com/google/uuid/blob/master/LICENSE,BSD-3-Clause >> < >> github.com/googleapis/gnostic,https://github.com/googleapis/gnostic/blob/master/LICENSE,Apache-2.0 >> < >> github.com/hashicorp/golang-lru,https://github.com/hashicorp/golang-lru/blob/master/LICENSE,MPL-2.0 >> < >> github.com/imdario/mergo,https://github.com/imdario/mergo/blob/master/LICENSE,BSD-3-Clause >> < >> github.com/json-iterator/go,https://github.com/json-iterator/go/blob/master/LICENSE,MIT >> < >> github.com/matttproud/golang_protobuf_extensions/pbutil,https://github.com/matttproud/golang_protobuf_extensions/blob/master/pbutil/LICENSE,Apache-2.0 >> < >> github.com/modern-go/concurrent,https://github.com/modern-go/concurrent/blob/master/LICENSE,Apache-2.0 >> < >> github.com/modern-go/reflect2,https://github.com/modern-go/reflect2/blob/master/LICENSE,Apache-2.0 >> < >> github.com/pkg/errors,https://github.com/pkg/errors/blob/master/LICENSE,BSD-2-Clause >> < >> github.com/pravega/zookeeper-operator/pkg/apis,https://github.com/pravega/zookeeper-operator/blob/master/pkg/apis/LICENSE,Apache-2.0 >> < >> github.com/prometheus/client_golang/prometheus,https://github.com/prometheus/client_golang/blob/master/prometheus/LICENSE,Apache-2.0 >> < >> github.com/prometheus/client_model/go,https://github.com/prometheus/client_model/blob/master/go/LICENSE,Apache-2.0 >> < >> github.com/prometheus/common,https://github.com/prometheus/common/blob/master/LICENSE,Apache-2.0 >> < >> github.com/prometheus/common/internal/bitbucket.org/ww/goautoneg,https://github.com/prometheus/common/blob/master/internal/bitbucket.org/ww/goautoneg/README.txt,BSD-3-Clause >> < >> github.com/prometheus/procfs,https://github.com/prometheus/procfs/blob/master/LICENSE,Apache-2.0 >> < >> github.com/spf13/pflag,https://github.com/spf13/pflag/blob/master/LICENSE,BSD-3-Clause >> < go.uber.org/atomic,Unknown,MIT >> < go.uber.org/multierr,Unknown,MIT >> < go.uber.org/zap,Unknown,MIT >> < golang.org/x/crypto/ssh/terminal,Unknown,BSD-3-Clause >> < golang.org/x/net,Unknown,BSD-3-Clause >> < golang.org/x/oauth2,Unknown,BSD-3-Clause >> < golang.org/x/sys,Unknown,BSD-3-Clause >> < golang.org/x/text,Unknown,BSD-3-Clause >> < golang.org/x/time/rate,Unknown,BSD-3-Clause >> < gomodules.xyz/jsonpatch/v2,Unknown,Apache-2.0 >> < google.golang.org/protobuf,Unknown,BSD-3-Clause >> < gopkg.in/inf.v0,Unknown,BSD-3-Clause >> < gopkg.in/yaml.v2,Unknown,Apache-2.0 >> < k8s.io/api,Unknown,Apache-2.0 >> < k8s.io/apiextensions-apiserver/pkg/apis/apiextensions,Unknown,Apache-2.0 >> < k8s.io/apimachinery,Unknown,Apache-2.0 >> < k8s.io/client-go,Unknown,Apache-2.0 >> < k8s.io/klog/v2,Unknown,Apache-2.0 >> < k8s.io/kube-openapi/pkg/util/proto,Unknown,Apache-2.0 >> < k8s.io/utils,Unknown,Apache-2.0 >> < sigs.k8s.io/controller-runtime,Unknown,Apache-2.0 >> < sigs.k8s.io/structured-merge-diff/v4/value,Unknown,Apache-2.0 >> < sigs.k8s.io/yaml,Unknown,MIT >> make: *** [check-licenses] Error 1 >> >> Jan >> >> 26. apr. 2021 kl. 17:26 skrev Houston Putman <houstonput...@gmail.com>: >> >> Jan, >> >> Anshum had the same issue. He was able to get past it by clearing his go/pkg >> directory and re-installing go 1.16. We think it had something to do with >> out-of-date dependencies in the cache. >> >> - Houston >> >> On Mon, Apr 26, 2021 at 10:17 AM Jan Høydahl <janhoy-apa...@cominvent.com> >> wrote: >>> >>> I ran the smoke tester but it failed with this error >>> >>> [...] >>> ./hack/check_license.sh >>> Check list of dependency licenses >>> go-licenses csv . 2>/dev/null | grep -v -E "solr-operator" | sort | diff >>> dependency_licenses.csv - >>> 0a1 >>> > ,Unknown,BSD-3-Clause >>> 53a55,58 >>> > vendor/golang.org/x/crypto,Unknown,BSD-3-Clause >>> > vendor/golang.org/x/net,Unknown,BSD-3-Clause >>> > vendor/golang.org/x/sys/cpu,Unknown,BSD-3-Clause >>> > vendor/golang.org/x/text,Unknown,BSD-3-Clause >>> make: *** [check-licenses] Error 1 >>> >>> Jan >>> >>> 24. apr. 2021 kl. 00:43 skrev Houston Putman <hous...@apache.org>: >>> >>> Please vote for release candidate 3 for the Solr Operator v0.3.0 >>> >>> The artifacts can be downloaded from: >>> https://dist.apache.org/repos/dist/dev/solr/solr-operator/solr-operator-v0.3.0-RC3-revf3cde99c406fedc748c49cfb57056f837a938ea0 >>> >>> You can run the full smoke tester, with instructions below. >>> However, it is also encouraged to go and use the artifacts yourself in a >>> test Kubernetes cluster. >>> The smoke tester does not require you to download or install the RC >>> artifacts before running. >>> If you plan on just running the smoke tests, then ignore all other >>> instructions. >>> >>> The artifacts are layed out in the following way: >>> * solr-operator-v0.3.0.tgz - Contains the source release >>> * crds/ - Contains the CRD files >>> * helm/ - Contains the Helm release packages >>> >>> The RC Docker image can be found at: >>> apache/solr-operator:v0.3.0-rc3 >>> >>> The RC Helm repo can be added with: >>> helm repo add solr-operator-rc >>> https://dist.apache.org/repos/dist/dev/solr/solr-operator/solr-operator-v0.3.0-RC3-revf3cde99c406fedc748c49cfb57056f837a938ea0/helm-charts >>> >>> You can install the RC Solr Operator and Solr CRDs with: >>> curl -sL0 "https://dist.apache.org/repos/dist/release/solr/KEYS"; | gpg >>> --import --quiet >>> # This will export your public keys into a format that helm can >>> understand. >>> # Skip verification by removing "--verify" in the helm command below. >>> if ! (gpg --no-default-keyring --keyring=~/.gnupg/pubring.gpg --list-keys >>> "98F3F6EC"); then gpg --export >~/.gnupg/pubring.gpg; fi >>> kubectl create -f >>> https://dist.apache.org/repos/dist/dev/solr/solr-operator/solr-operator-v0.3.0-RC3-revf3cde99c406fedc748c49cfb57056f837a938ea0/crds/all-with-dependencies.yaml >>> || \ >>> kubectl replace -f >>> https://dist.apache.org/repos/dist/dev/solr/solr-operator/solr-operator-v0.3.0-RC3-revf3cde99c406fedc748c49cfb57056f837a938ea0/crds/all-with-dependencies.yaml >>> helm install --verify solr-operator solr-operator-rc/solr-operator --set >>> image.tag=v0.3.0-rc3 >>> >>> You can run the full smoke tester directly with this command: (First >>> checkout the release-0.3 branch of the solr-operator) >>> >>> ./hack/release/smoke_test/smoke_test.sh -v "v0.3.0" -s "f3cde99" -i >>> "apache/solr-operator:v0.3.0-rc3" -g "98F3F6EC" \ >>> -l >>> 'https://dist.apache.org/repos/dist/dev/solr/solr-operator/solr-operator-v0.3.0-RC3-revf3cde99c406fedc748c49cfb57056f837a938ea0' >>> >>> Make sure you have the following installed before running the smoke test: >>> - Docker (Give it enough memory and CPU to run ~12 containers, 3 of which >>> are Solr nodes) >>> - Go 1.16 >>> - Kubectl >>> - GnuPG >>> - Helm v3.4.0+ >>> - Kustomize (v4.0.0+) This will be installed for you, but NOT upgraded if >>> a lower version is already installed. >>> - yq >>> - jq >>> - coreutils (if using Mac OS) >>> >>> The vote will be open for at least 72 hours i.e. until 2021-04-28 23:00 >>> UTC. (Extended for the weekend) >>> >>> [ ] +1 approve >>> [ ] +0 no opinion >>> [ ] -1 disapprove (and reason why) >>> >>> Here is my +1 >>> >>> >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org For additional commands, e-mail: dev-h...@solr.apache.org
