You did a really great write up, going to have to read it again ;-) As far as your first point on the Eclipse flagging unused imports, a PR to fix that would be welcome. You are pointing to a larger issue which is that we don’t have very good linting of our code. I looked at our gradle build a bit, and it looks like we are using a tool called “spotless” for potentially enforcing code formatting. https://issues.apache.org/jira/browse/SOLR-14920 appears to go into detail on this.
One thought is that it would be interesting to look at a PR that fixes the unused import and adds an actual check for that to Spotless. I see that there is a technique they call “ratcheting” to slowly apply code formatting checks over time via CI/CD as a file is changed for other reasons. Unused imports might be a nice non controversial start! > On Jan 1, 2022, at 2:31 PM, Mark Miller <[email protected]> wrote: > > Yeah that’s a pretty crappy situation for a new contributor. > > You basically have to make some educated guesses. Do more tests fail on > average after your patch than before? Are the fails in tests that you added > or in tests that look related (test with backup in the name for example)? > > If the fails doesn’t seem related to your changes, you pretty much leave it > on whoever might commit your code to use their deeper experience or luckier > dev environment to get your changes in regards to unrelated tests. > > That pretty much dictates you want to run the tests a fair amount to help you > gauge. To do that reasonably, you need to crank up the parallel. Almost all > of the longer tests do very little actual work - so you can run a lot of them > together as long as you have the RAM for it. On any decent modern hardware, > you ought to be able to run them in at most 40 some minutes in most cases. > With good hardware and the right parralel test settings, you should be able > to do more like 10-20 min. _______________________ Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com <http://www.opensourceconnections.com/> | My Free/Busy <http://tinyurl.com/eric-cal> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
