Reopened the issue, because the tests are in fact not fixed yet. Working on
it now.

On Wed, Jan 12, 2022 at 11:07 AM Jan Høydahl <j...@cominvent.com> wrote:

> Hi,
>
> Yes, I touched the part checking version constraint, and added the check
> for invalid SemVer expression syntax when adding SolrVersion class.
> Earlier an invalid expression in a package manifest would print "Version
> incompatible!..." and exit. After the change it will print "Error in
> version constraint given in package manifest" and exit. So end game would
> be the same.
>
> I believe that PackageManager is only ever invoked from CLI. But when
> invoked from a test, the System.exit is dubious.
>
> Jan
>
> 12. jan. 2022 kl. 05:34 skrev David Smiley <dsmi...@apache.org>:
>
> org.apache.solr.cloud.PackageManagerCLITest
> Is usually failing:
> http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.cloud.PackageManagerCLITest.testPackageManager
> Based on a quick, look, it seems that the package manager is calling
> System.exit, which isn't allowed by the Lucene's test SecurityManager that
> we're using.  The relevant code was recently touched by Jan but the
> System.exit's have been there for a while.
>
> ~ David Smiley
> Apache Lucene/Solr Search Developer
> http://www.linkedin.com/in/davidwsmiley
>
>
>

Reply via email to