+1 (binding) but flaky tests are in sad shape; not worth holding up a release over.
I ran the smoke tester and only one test failed: org.apache.solr.servlet.TestRequestRateLimiter.testConcurrentQueries However this test I recall from conversations has some known flakiness. But moreover, actually tons of tests are showing up as failing very often in http://fucit.org/solr-jenkins-reports/failure-report.html (this test is maybe in the middle; there are plenty worse). I suppose it's adequate. I wish the smoketester ran the tests as the very last step and not prior to other checking. "checkMaven" happens after. I then repeated with --test-java17 and got 3 different errors. But there were clues the failures occured from Java 11 VMs, not 17. Looking at the smoketester script, it appears java17 is run _after_ java 11; so it never made it this far. I commented out Java 11 tests (because they were faiing) and ran again so that the Java 17 ones would run. Again, 2-3 test failed. I did the docker build as instructed and I complete the Solr Text Tagger tutorial. Worked fine. I'd like to try out the maven dependencies in a side project, since it was observed there were issues. I'm on travel at the moment but if someone has tips on where to locate them / how to use them (anything non-obvious), I'd appreciate it. BTW thanks to everyone (esp. Jan & Houston) doing the legwork of doing the release. And the manual release checking I see most of you do -- very important. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Wed, Apr 27, 2022 at 9:15 AM Jan Høydahl <[email protected]> wrote: > Please vote for release candidate 4 for Solr 9.0.0 > > The artifacts can be downloaded from: > > https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC4-rev-d6e36d590896755ca962c6d2ddedf78ca4f463cc > > You can run the smoke tester directly with this command: > > python3 -u dev-tools/scripts/smokeTestRelease.py \ > > https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC4-rev-d6e36d590896755ca962c6d2ddedf78ca4f463cc > > You are encouraged to do an extra thorough test and manual inspection > beyond > running the smoketester, since this is a major release. > > You can build a release-candidate of the official docker image using the > following command: > > DIST_BASE=https://dist.apache.org/repos/dist/dev/solr && \ > RC_FOLDER=solr-9.0.0-RC4-rev-d6e36d590896755ca962c6d2ddedf78ca4f463cc && > \ > docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \ > --build-arg SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \ > -t solr-rc:9.0.0-4 > > The vote will be open for at least 72 hours i.e. until 2022-04-30 13:00 > UTC. > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > Here is my +1 > > SUCCESS! [0:56:56.134141] > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
