> I knew we lost the tabs but thought it didn’t look *terrible*

That was my impression exactly.  I like the tabs of course, but was
surprised with how decent things still look without them.  It's not bad at
all!

Thanks for the info Cassandra!  I'll file a ticket so this is written down
somewhere and take a crack at it, see if it isn't in my limited JS/CSS
wheelhouse haha.

Best,

Jason

On Fri, May 13, 2022 at 4:21 PM Cassandra Targett <[email protected]>
wrote:

> We got those tabs from Bootstrap which had built-in support for them
> (they’re called “navs”: https://getbootstrap.com/docs/4.6/components/navs/
> ).
>
> Due to the way Antora deals with the UI for a docs site, I did not try to
> re-implement the bootstrap framework and all that - it was simpler to try
> to take Antora’s default UI files and edit those to make it look vaguely
> similar to what we had. But a casualty was that tab functionality. I knew
> we lost the tabs but thought it didn’t look *terrible* with how it came out
> without it - I might have vaguely meant to go back to it, but didn’t.
>
> I expect it’d be a bit complex to re-implement it since we’re not using a
> framework that supports it out of the box, and then of course it needs to
> be templatized too. Feel free IMO take a stab at it if you want. Even if we
> can’t go back to the tabs maybe some styling would be an alternative
> improvement.
>
> Cassandra
> On May 13, 2022, 2:59 PM -0500, Jason Gerlowski <[email protected]>,
> wrote:
>
> Hey all,
>
> Some pages in the ref-guide display multiple code snippets in a "tabbed"
> UI widget that lets readers select which of the N snippets they want to
> look at.  This lets us display multiple related examples in a compact way.
> It's mostly used for v1/v2 API examples, etc.  But starting with the 9.0
> guide, these previously tabbed snippets now appear "serially" one after
> another on the page.  (For an example, see:
> https://solr.apache.org/guide/solr/9_0/deployment-guide/collection-management.html
> )
>
> Does anyone know if this was intentional?  If it is a bug, IMO it's not a
> huge deal, or anything worth holding up the ref-guide release for.  But if
> it wasn't intentional I'll file a ticket and maybe take a crack for 9.1.
>
> Best,
>
> Jason
>
>

Reply via email to