Thanks for reviewing this David. Please feel free to merge it :) On Wed, Aug 7, 2024 at 2:37 PM David Smiley <dsmi...@apache.org> wrote:
> Anshum, please review the following: > > Prometheus Response Writer: > * https://github.com/apache/solr/pull/2616 fixes the content type. > Very trivial; ready to merge. No CHANGES.txt needed as it improves > the existing merged work. > * FYI there's another PR that does an internal class rename to avoid > confusion before we ship this; it'd be nice to merge this too if you > let me :-) > > ThreadPoolExecutor configuration affecting multiple features albeit one PR: > * bad performance for backups of large collections > * new multiThreaded executor configuration > * nonoptimal for update log replay > See this issue and especially this comment: > > https://issues.apache.org/jira/browse/SOLR-17391?focusedCommentId=17871790&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17871790 > The PR is ready IMO albeit missing CHANGES.txt. I'd be happy to move it > along. > Hats off to my colleague Pierre for spotting a really useful option > "allowCoreThreadTimeOut" > > On Tue, Aug 6, 2024 at 4:31 PM Anshum Gupta <ans...@anshumgupta.net> > wrote: > > > > Yup, realized the 'release wizard early' bit :) > > > > The wizard is wonderful, specially as the last time I released it was the > > manual process! > > > > On Tue, Aug 6, 2024 at 11:25 AM Gus Heck <gus.h...@gmail.com> wrote: > > > > > Yeah release wizard early... see my writeup here: > > > > > > > https://github.com/apache/solr/blob/main/dev-docs/releasing.adoc#step-1-run-the-release-wizard > > > (and feel free to add to it) > > > > > > Also you'll want to peek at > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20SOLR%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20release-scripts%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC > > > for a list of gotchas > > > > > > On Tue, Aug 6, 2024 at 12:25 PM Anshum Gupta <ans...@anshumgupta.net> > > > wrote: > > > > > > > Thanks for letting me know, Houston and David. I'll take a look and > take > > > > care of that. > > > > > > > > On Mon, Aug 5, 2024 at 9:28 PM Houston Putman <hous...@apache.org> > > > wrote: > > > > > > > > > It is in there. Definitely start the steps now anshum. You dont > have to > > > > be > > > > > ready to do the release to do the first 1/3 of them. > > > > > > > > > > On Mon, Aug 5, 2024 at 10:54 PM David Smiley <dsmi...@apache.org> > > > wrote: > > > > > > > > > > > Does the release wizard not have the next version (9.8) in JIRA > get > > > > > > created? Ideally that is done with the branch freezing so as to > > > > > > resolve JIRA issues not making the release. > > > > > > > > > > > > On Mon, Aug 5, 2024 at 11:44 PM David Smiley <dsmi...@apache.org > > > > > > wrote: > > > > > > > > > > > > > > This change here is a super simple fix to the new > > > > > > > PrometheusResponseWriter mime type: > > > > > > > https://github.com/apache/solr/pull/2616 > > > > > > > I'd like to get this in. > > > > > > > > > > > > > > On Mon, Aug 5, 2024 at 3:46 PM Anshum Gupta < > > > ans...@anshumgupta.net> > > > > > > wrote: > > > > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > > > I've created the release branch for 9.7. Can you please let > me > > > know > > > > > > what's > > > > > > > > pending and needs to still make it into the release? > > > > > > > > > > > > > > > > Thanks! > > > > > > > > > > > > > > > > -- > > > > > > > > Anshum Gupta > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > > > > > > For additional commands, e-mail: dev-h...@solr.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Anshum Gupta > > > > > > > > > > > > > -- > > > http://www.needhamsoftware.com (work) > > > https://a.co/d/b2sZLD9 (my fantasy fiction book) > > > > > > > > > -- > > Anshum Gupta > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > For additional commands, e-mail: dev-h...@solr.apache.org > > -- Anshum Gupta
