Hi Solr devs,

Can someone please review the PR #3750, which adds an Azure Blob Storage
backup repository module for Solr:

https://github.com/apache/solr/pull/3750
JIRA: https://issues.apache.org/jira/browse/SOLR-17949

Summary:

- New solr:modules:azure-blob-repository module implementing
BackupRepository for Azure Blob Storage, following the structure of the
S3/GCS modules.
- Four authentication methods: connection string, account key, SAS token,
and Azure Identity (Managed Identity / Service Principal / Azure CLI).
- Full and incremental backup/restore, including Install Shard.
- Tested against Azurite (emulator, via Testcontainers) in CI, plus manual
verification against a real Azure account for the auth methods CI can't
exercise.

On review coverage specifically: the module now runs the same shared
SolrCloud suites used by S3 and GCS - AbstractBackupRepositoryTest,
AbstractIncrementalBackupTest, and AbstractInstallShardTest.

Jan (janhoy) and Pierre (psalagnac) reviewed earlier revisions and flagged
some real issues,  all of which are fixed as of the latest push. I've
re-merged main to pick up recent build changes as well.

Given it's a new module rather than a change to existing code, I'd
appreciate either a review from someone already familiar with the backup
repository contract or a few eyes from anyone interested in Azure support
in Solr.

Happy to walk through any part of the design or answer questions here or on
the PR.

Thanks for your time,
Prateek

Reply via email to