http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4190
------- Additional Comments From [EMAIL PROTECTED] 2005-11-01 10:50 ------- Created an attachment (id=3224) --> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3224&action=view) child_handler() call correction First - If child_handler() is called after sleep() (for paranoia's sake), then it should be passed an arg - signal name ('CHLD') So the call should look like child_handler('CHILD'); It will eliminate "Use of uninitialized value..." warinng and the log mesg will appear properly "server hit by SIGCHLD", not truncated "server hit by SIG". The attached patch has this correction. By the way the child_handler() call should be changed in the 3.1.x branch also. I tried this patch with 3.0.3, it works fine. There were two corrections in the original patch: the time-limited sleep and the child_handler call. Actually I don't see much benefit from this child_handler() call here, but if you prefer to make this call I am sure it will not harm anyway (except for littering log with fake "server hit by SIGCHLD" messages). Turning the sleep; into the time-limited sleep 10; in the main processing loop can't cause spamd dying also anyway. So I believe this patch is not the reason of the spamd crash and the patch works fine with 3.0.3 As a result: child_handler(); call after sleep; should be turned into child_handler('CHLD'); call or it should be removed altogether. It should be done for both 3.1.x and 3.0.x branches. Best regards, Alexey Kravchuk ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
