-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Theo Van Dinter writes:
> I was just noticing that my test rules which use my sandbox-felicity.pm plugin
> aren't hitting any mails.  Doing some debugging, I found that the loadplugin
> line occurs after all of the rules and their respective ifplugin areas.
> 
> I also noticed that Henry has a plugin whose loadplugin line doesn't even
> appear in the rules dir after a mkrules run, due to this error which I
> mentioned a few weeks ago:
> 
> rulesrc/sandbox/hstern/70_syndicate.cf: WARNING: 'rules/sandbox-hstern.pm' not
> listed in manifest file, line ignored: loadplugin
> Mail::SpamAssassin::Plugin::Sandbox::hstern sandbox-hstern.pm
> 
> I added it to the MANIFEST file so the line will be used, but the loadplugin
> has the same problem as mine does -- it comes after the use point.

Yeah, I think I raised this a week or two back.
In my opinion, a sandbox plugin file should *not* be listed in the
MANIFEST -- since we don't want to distribute sandbox code via:

    - "make install"
    - distributed tarballs
    - sa-update

There's no guarantee that sandbox code will be of a distributable quality,
yet.  As a result we should not distribute .pm's from the sandbox dir, and
only distribute .pm's from "rules" or "rulesrc/core".  Neither .pm should
be listed in MANIFEST, accordingly.

cf. also http://wiki.apache.org/spamassassin/RuleLifeCycle .

Let me know if that doesn't make sense, or if it's wrong. ;)

- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFD38AkMJF5cimLx9ARAi6FAJ4tJ9Q4QcsdUF/47l9C0urr5BU8bgCfS14h
64JVMpD2Bzt/CdWKoFwSr/o=
=uUn2
-----END PGP SIGNATURE-----

Reply via email to