http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4935
------- Additional Comments From [EMAIL PROTECTED] 2006-06-20 23:47 -------
+1
I think it's generally good, though I would have written:
+ tie %{ $self->{accum} }, $dbm_module, $path, $mod2,
+ oct($main->{conf}->{auto_whitelist_file_mode})
+ or do {
+ my $err = $!; # might get overwritten later
+ if ($self->{is_locked}) {
+ $self->{main}->{locker}->safe_unlock($self->{locked_file});
+ $self->{is_locked} = 0;
+ }
+ die "auto-whitelist: cannot open auto_whitelist_path $path: $err\n";
+ };
to be similar to:
if (! tie .... ) {
...
}
since that would match how things are done in the rest of the code.
It's a trivial change though, so we can change it later. :)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
