http://issues.apache.org/SpamAssassin/show_bug.cgi?id=3109





------- Additional Comments From [EMAIL PROTECTED]  2006-07-19 00:20 -------
> Here is a new, less-intrusive short-circuiting patch against trunk.
> 
> It moves the implementation to a plugin,

YAY!!!!

> Mail::SpamAssassin::Plugin::Shortcircuit, which implements the s/c logic. This
> is made possible with a new plugin API and a flag-setting API on the
> PerMsgStatus object.
> 

Why not pass all the other available values into handle_hit?

> It is still necessary to dot the PerMsgStatus code with calls like:
> 
>    return if (exists $self->{shortcircuit_flag});

Why not make this into some sort of plugin call?

> 
> I can't see a way to do it efficiently otherwise, unfortunately.  Other
> than that, though, the logic is all now in a plugin; in particular,
> deciding *when* that flag is set all takes place there.
> 

I think that the changes are too specific, and I'd like to make it even more
generic.  It would be easy to give this lots more love with a Check.pm plugin 
BTW :)

Also, I strongly, in the -1 veto type of disagreement, with having shortcircuit
turned on by default.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to