https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6246

           Summary: 3.3.0 beta1/SVN fails make test if Mail::DKIM is not
                    0.36_5 or higher
           Product: Spamassassin
           Version: 3.3.0
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: blocker
          Priority: P5
         Component: Regression Tests
        AssignedTo: [email protected]
        ReportedBy: [email protected]


Created an attachment (id=4585)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4585)
Very Simple Patch to require a newer DKIM module for install of SA

re: 3.3.0 beta1, I generally don't like seeing a release go out that has known
make test failures.

Currently, I'm failing on this:

t/dkim2...........................ok 32/123     Not found: 
DKIM_ADSP_NXDOMAIN =  DKIM_ADSP_NXDOMAIN  at t/dkim2.t line 85.
# Failed test 120 in t/SATest.pm at line 716


Turning on verbose tests, I found this output:

        Checking for anti-pattern DKIM_ADSP_ALL at t/dkim2.t line 85.


*** Mail::DKIM 0.36, Test 120 is expected to fail with versions older than 
0.36_5
ok 121


I'd like to either A) see that warning in non-verbose tests, B) Makefile.PL 
modified on line 185 to say 'Mail::DKIM'    => 0.36_5, or C) see a warning 
from the Makefile.PL advising they upgrade if not require it before I +1.

I suggest solution B and submitting a patch for this purpose.

After upgrading Mail::DKIM to 0.37, I've confirmed that the test passes and all
other tests with make tests with net_tests enabled looks good.

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to