https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6246

--- Comment #10 from Kevin A. McGrail <[email protected]> 2009-12-06 17:41:07 
UTC ---
Sorry, I was approving your DependencyInfo.pm patch.  I don't like the option D
as it leads to limited functionality but I do agree that the work you put into
supporting older versions is good and valuable.

However, the DependencyInfo patch has a small logic issue somewhere:

Here's the output from perl Makefile.PL with DKIM 0.28 installed for testing
purposes:

***************************************************************************
NOTE: the optional Mail::DKIM (version 0.31) module is installed,
but is not an up-to-date version.

  If this module is installed and the DKIM plugin is enabled,
  SpamAssassin will perform DKIM signature verification when DKIM-Signature
  header fields are present in the message headers, and check ADSP rules
  (e.g. anti-phishing) when a mail message does not contain a valid author
  domain signature. Version 0.36_5 or later is needed to fully support ADSP.


Warning: prerequisite Mail::DKIM 0.31 not found. We have 0.28.

If below 0.31 (required) I woudln't show the optional installation message at
all as 0.31 is the minimum.

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to