https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7170
Kevin A. McGrail <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #4 from Kevin A. McGrail <[email protected]> --- (In reply to Mark Martinec from comment #3) > > Committed revision 1672426. > > - $uri = Mail::SpamAssassin::Util::RegistrarBoundaries::trim_domain($uri); > > + $uri = Mail::SpamAssassin::RegistryBoundaries::trim_domain($uri); > > > > - (Mail::SpamAssassin::Util::RegistrarBoundaries::is_domain_valid($uri)); > > + (Mail::SpamAssassin::RegistryBoundaries::is_domain_valid($uri)); > > Does this work??? The is_domain_valid and trim_domain in RegistryBoundaries > are methods ($self as the first argument), while in RegistrarBoundaries > they were plain subroutines. I would assume it does not work that simply and had relied on the 1:1. Henrik, can you please look at M:S:Util for the move of trim_domain and is_domain_valid to RegistryBoundaries? Mark is certainly write it can't be correct. > Could/should the Util::uri_to_domain be turned into a thin wrapper > around RegistryBoundaries::uri_to_domain instead of duplicating the code? I considered that but I'm considering it deprecated and want 3rd party plugins people to move to RegistryBoundaries ASAP. -- You are receiving this mail because: You are the assignee for the bug.
