https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7170
Kevin A. McGrail <kmcgr...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|minor |blocker
Target Milestone|Undefined |3.4.2
--- Comment #6 from Kevin A. McGrail <kmcgr...@pccc.com> ---
I realized the function in Util.pm is also being deprecated and should not be
changed to the new function. I'm an idiot. Thanks for the catch Mark
I have reversed my change. And UPGRADE for 3.4.1 needs to note that:
Mail::SpamAssassin::Util::RegistrarBoundaries is being replaced by
Mail::SpamAssassin::RegistryBoundaries so that new TLDs can be updated via
20_aux_tlds.cf delivered via sa-update.
***3rd Party Plugin Authors, Please Note***
The following functions will be removed in the next release after 3.4.1
excepting any emergency break/fix releases immediately after 3.4.1:
Mail::SpamAssassin::Util::RegistrarBoundaries::is_domain_valid
Mail::SpamAssassin::Util::RegistrarBoundaries::trim_domain
Mail::SpamAssassin::Util::RegistrarBoundaries::split_domain
Mail::SpamAssassin::Util::uri_to_domain
And the following variables will also be removed:
Mail::SpamAssassin::Util::RegistrarBoundaries::US_STATES
Mail::SpamAssassin::Util::RegistrarBoundaries::THREE_LEVEL_DOMAINS
Mail::SpamAssassin::Util::RegistrarBoundaries::TWO_LEVEL_DOMAINS
Mail::SpamAssassin::Util::RegistrarBoundaries::VALID_TLDS_RE
Mail::SpamAssassin::Util::RegistrarBoundaries::VALID_TLDS
This change should only affect 3rd party plugin authors who will need to update
their code to utilize Mail::SpamAssassin::RegistryBoundaries instead of the
functions and variables in Mail::SpamAssassin::Util::RegistrarBoundaries and
the function Mail::SpamAssassin::Util::uri_to_domain which are deprecated and
will be removed.
svn commit -m 'reversed my change on the deprecated function and cleaned up
UPGRADE for RegistrarBoundaries impending removal - Bug 7170'
Sending UPGRADE
Sending lib/Mail/SpamAssassin/Util.pm
Transmitting file data ..
Committed revision 1672441.
I've added the above to UPGRADE and hence this ticket is now a ticket of what
needs to be removed for the next release after 3.4.1 (which might be 3.4.2
unless we have a breakfix release(s) after 3.4.1):
- A few weeks after 3.4.1 is released and solid (i.e. not needing an emergency
3.4.2), trunk should be modified to remove RegistrarBoundaries.pm
- Also, the function uri_to_domain in M:S:Util should be removed
- The text for uri_text.t from bug 7166 needs to be resolved because when
RegistrarBoundaries is removed, we'll fail the entire test, I believe.
--
You are receiving this mail because:
You are the assignee for the bug.
