https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8529
Bug ID: 8529
Summary: Perlcritic issues on some Linux versions
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Libraries
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: 4.0.3
Some Linux versions fails perlcritic tests.
# Failed test 'Test::Perl::Critic for "../blib/script/sa-update"'
# at /opt/perl-5.44.0/lib/site_perl/5.44.0/Test/Perl/Critic.pm line 121.
#
# [ProhibitPipeOpen] Pipe "open" used at line 939, near 'open(CMD, "$CMD
$sig_file $content_file|")'. (Severity: 5)
# [ProhibitPipeOpen] Pipe "open" used at line 1901, near 'open(CMD, "$CMD
$keyfile|")'. (Severity: 5)
# Failed test 'Test::Perl::Critic for
"../blib/lib/Mail/SpamAssassin/ArchiveIterator.pm"'
# at /opt/perl-5.44.0/lib/site_perl/5.44.0/Test/Perl/Critic.pm line 121.
#
# [ProhibitPipeOpen] Pipe "open" used at line 666, near '!open($fh, '-|',
$self->{bzip2_path}, '-cd', $file)'. (Severity: 5)
# [ProhibitPipeOpen] Pipe "open" used at line 680, near '!open($fh, '-|',
$self->{xz_path}, '-cd', $file)'. (Severity: 5)
# [ProhibitPipeOpen] Pipe "open" used at line 694, near '!open($fh, '-|',
$self->{lz4_path}, '-cd', $file)'. (Severity: 5)
# [ProhibitPipeOpen] Pipe "open" used at line 708, near '!open($fh, '-|',
$self->{lzip_path}, '-cd', $file)'. (Severity: 5)
# [ProhibitPipeOpen] Pipe "open" used at line 722, near '!open($fh, '-|',
$self->{lzop_path}, '-cd', $file)'. (Severity: 5)
# Failed test 'Test::Perl::Critic for
"../blib/lib/Mail/SpamAssassin/Util.pm"'
# at /opt/perl-5.44.0/lib/site_perl/5.44.0/Test/Perl/Critic.pm line 121.
#
# [ProhibitPipeOpen] Pipe "open" used at line 2051, near '$pid = open ($fh,
'-|');'. (Severity: 5)
# Failed test 'Test::Perl::Critic for
"../blib/lib/Mail/SpamAssassin/Plugin/DCC.pm"'
# at /opt/perl-5.44.0/lib/site_perl/5.44.0/Test/Perl/Critic.pm line 121.
#
# [ProhibitPipeOpen] Pipe "open" used at line 460, near '$cdcc && open(CDCC,
"$cdcc $cmd 2>&1 |")'. (Severity: 5)
# Failed test 'Test::Perl::Critic for
"../blib/lib/Mail/SpamAssassin/Plugin/BodyRuleBaseExtractor.pm"'
# at /opt/perl-5.44.0/lib/site_perl/5.44.0/Test/Perl/Critic.pm line 121.
#
# [ProhibitPipeOpen] Pipe "open" used at line 561, near 'open (IN,
"$self->{perl} -c -Mre=debug $self->{tmpf} 2>&1 |")'. (Severity: 5)
# Failed test 'Test::Perl::Critic for
"../blib/lib/Mail/SpamAssassin/PDF/Filter/FlateDecode.pm"'
# at /opt/perl-5.44.0/lib/site_perl/5.44.0/Test/Perl/Critic.pm line 121.
#
# [Objects::ProhibitIndirectSyntax] Subroutine "new" called using indirect
syntax at line 25, near 'my $i = new Compress::Raw::Zlib::Inflate(
-AppendOutput => 1 );'. (Severity: 5)
# [Objects::ProhibitIndirectSyntax] Subroutine "new" called using indirect
syntax at line 25, near 'my $i = new Compress::Raw::Zlib::Inflate(
-AppendOutput => 1 );'. (Severity: 5)
# Failed test 'Test::Perl::Critic for
"../blib/lib/Mail/SpamAssassin/BayesStore/DBM.pm"'
# at /opt/perl-5.44.0/lib/site_perl/5.44.0/Test/Perl/Critic.pm line 121.
#
# [ControlStructures::ProhibitBareBlockLoopControls] 'last' in "do" block at
line 1161, near 'last;'. (Severity: 5)
# [ControlStructures::ProhibitBareBlockLoopControls] 'last' in "do" block at
line 1173, near 'last;'. (Severity: 5)
t/perlcritic.t ....................
Dubious, test returned 1 (wstat 256, 0x100)
more details at
https://matrix.cpantesters.org/?dist=Mail-SpamAssassin%204.0.3-rc3-TRIAL0
--
You are receiving this mail because:
You are the assignee for the bug.
