https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8529
--- Comment #2 from Sidney Markowitz <[email protected]> --- Created attachment 6231 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=6231&action=edit fix the code flagged by new perlcritic policies, and exclude ProhibitPipeOpen The failures are reported by three policies. Two come from policy distributions that are not part of Perl::Critic and were released this year, ControlStructures::ProhibitBareBlockLoopControls from Perl-Critic-PolicyBundle-LoopsAndLabels and ProhibitPipeOpen from perl-critic-policy-prohibitpipeopen, which are installed on the test machines that reported the failures. The third, Objects::ProhibitIndirectSyntax, is a standard Perl::Critic policy, but those machines report it at severity 5 instead of its default 4. ControlStructures::ProhibitBareBlockLoopControls flags a real bug in BayesStore/DBM.pm that goes back to 3.0.0: an error while writing the Bayes journal, such as a full disk, is not handled correctly. The patch changes the journal loop there to a while loop. The same policy flags harmless code in Plugin/P595Body.pm, an experimental plugin that is not in releases but is checked by the test in an svn checkout, and the patch removes an unneeded block there. The code in PDF/Filter/FlateDecode.pm that triggers Objects::ProhibitIndirectSyntax is not a bug, but is easy to fix so the policy is not triggered. ProhibitPipeOpen flags our intentional use of pipe opens. This patch adds that policy to the exclude list in the test. +1 from me to commit to 4.0.3 Two more votes needed -- You are receiving this mail because: You are the assignee for the bug.
