Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/33#discussion_r10149280
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -557,7 +754,54 @@ private[spark] class ConnectionManager(port: Int,
conf: SparkConf) extends Loggi
// useful in our test-env ... If we do re-add it, we should
consistently use it everywhere I
// guess ?
val connection = connectionsById.getOrElseUpdate(connectionManagerId,
startNewConnection())
+ if (authEnabled) {
+ checkSendAuthFirst(connectionManagerId, connection)
+ }
message.senderAddress = id.toSocketAddress()
+ logDebug("Before Sending [" + message + "] to [" + connectionManagerId
+ "]" + " " +
--- End diff --
is this log statement O(messages sent) or just O(authentication messages).
If it's the former, it would be good to make it logTrace. Also, if there is any
other code in here that logs on every message it would be good to make that
trace-level. Otherwise the debug log is not consumable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
