Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/106#discussion_r10414905
  
    --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDD.scala ---
    @@ -135,7 +135,11 @@ class JavaRDD[T](val rdd: RDD[T])(implicit val 
classTag: ClassTag[T])
       def subtract(other: JavaRDD[T], p: Partitioner): JavaRDD[T] =
         wrapRDD(rdd.subtract(other, p))
     
    -  def generator: String = rdd.generator
    +  /**
    +   * @deprecated The 'generator' field was removed in Spark 1.0.0. Use 
sc.setJobGroup.
    +   */
    +  @Deprecated
    +  def generator: String = ""
    --- End diff --
    
    Since we've made these methods no longer do what they were intended to do, 
I wonder if it's preferable to simply throw an UnsupportedOperationException if 
they're called (with a deprecation message) rather than pretending everything 
is hunky-dory.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to