Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/106#discussion_r10414992
  
    --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDD.scala ---
    @@ -135,7 +135,11 @@ class JavaRDD[T](val rdd: RDD[T])(implicit val 
classTag: ClassTag[T])
       def subtract(other: JavaRDD[T], p: Partitioner): JavaRDD[T] =
         wrapRDD(rdd.subtract(other, p))
     
    -  def generator: String = rdd.generator
    +  /**
    +   * @deprecated The 'generator' field was removed in Spark 1.0.0. Use 
sc.setJobGroup.
    +   */
    +  @Deprecated
    +  def generator: String = ""
    --- End diff --
    
    This is sort of a special case because it wasn't previously a documented 
feature or something that (IMO) was ever used by anyone. My feeling was that if 
someone happens to be using this I'd rather just have them get degraded 
behavior than have a compile error or exception when running their job.
    
    In general this is not a proper deprecation because actually we are 
removing the functionality not just giving a warning.
    
    Wrt the other question, I think we'll probably follow semver 
http://semver.org/ which says you have to give a full minor release w/ the 
deprecation warning before removing it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to