Sent a pull request. (https://github.com/apache/spark/pull/899) Thanks.
-----Original Message----- From: Reynold Xin [mailto:r...@databricks.com] Sent: Wednesday, May 28, 2014 10:12 AM To: dev@spark.apache.org Subject: Re: About JIRA SPARK-1825 It is actually pretty simple. You will first need to fork Spark on github, and then push your changes to it, and then follow: https://help.github.com/articles/using-pull-requests On Tue, May 27, 2014 at 6:10 PM, innowireless TaeYun Kim < taeyun....@innowireless.co.kr> wrote: > I'm afraid I don't know how to send a 'pull request'. (Sorry for my > ignorance) > I've modified the source code on my PC. > I can learn how to send a pull request, or I can attach the modified > source code on the mail right now(only 2 scala files). > Which way is preferable? > > > -----Original Message----- > From: Matei Zaharia [mailto:matei.zaha...@gmail.com] > Sent: Wednesday, May 28, 2014 9:53 AM > To: dev@spark.apache.org > Subject: Re: About JIRA SPARK-1825 > > Hei Taeyun, have you sent a pull request for this fix? We can review > it there. > > It's too late to merge anything but blockers for 1.0.0 but we can do > it for > 1.0.1 or 1.1, depending how big the patch is. > > Matei > > On May 27, 2014, at 5:25 PM, innowireless TaeYun Kim > <taeyun....@innowireless.co.kr> wrote: > > > Could somebody please review and fix > > https://issues.apache.org/jira/browse/SPARK-1825 ? > > > > It's a cross-platform issue. > > > > I've fixed the Spark source code based on rc5 and it's working for > > me > now. > > but totally not sure whether I've done correctly, since I'm almost > > new to Spark and don't know much about the source code or API of > > both Spark and YARN. > > > > > > > > It would be nice that the issue be resolved before the 1.0.0 release. > > > > Without the fix, developing a Spark application on Windows will be > > inconvenient. > > > > > > > > I have the source code I've fixed, but I don't' know how to upload > > it to be shown by other, more Spark-capable developers. (And I'm not > > sure that my fix is correct) > > > > > > > > Thanks in advance. > > > > > > > >
