The hard part here is updating the existing code base... which is going to create merge conflicts with like all of the open PRs...
On Wed, Oct 1, 2014 at 6:13 PM, Nicholas Chammas <nicholas.cham...@gmail.com > wrote: > Ah, since there appears to be a built-in rule for end-of-line whitespace, > Michael and Cheng, y'all should be able to add this in pretty easily. > > Nick > > On Wed, Oct 1, 2014 at 6:37 PM, Patrick Wendell <pwend...@gmail.com> > wrote: > > > Hey Nick, > > > > We can always take built-in rules. Back when we added this Prashant > > Sharma actually did some great work that lets us write our own style > > rules in cases where rules don't exist. > > > > You can see some existing rules here: > > > > > https://github.com/apache/spark/tree/master/project/spark-style/src/main/scala/org/apache/spark/scalastyle > > > > Prashant has over time contributed a lot of our custom rules upstream > > to stalastyle, so now there are only a couple there. > > > > - Patrick > > > > On Wed, Oct 1, 2014 at 2:36 PM, Ted Yu <yuzhih...@gmail.com> wrote: > > > Please take a look at WhitespaceEndOfLineChecker under: > > > http://www.scalastyle.org/rules-0.1.0.html > > > > > > Cheers > > > > > > On Wed, Oct 1, 2014 at 2:01 PM, Nicholas Chammas < > > nicholas.cham...@gmail.com > > >> wrote: > > > > > >> As discussed here <https://github.com/apache/spark/pull/2619>, it > > would be > > >> good to extend our Scala style checks to programmatically enforce as > > many > > >> of our style rules as possible. > > >> > > >> Does anyone know if it's relatively straightforward to enforce > > additional > > >> rules like the "no trailing spaces" rule mentioned in the linked PR? > > >> > > >> Nick > > >> > > >
