I've created SPARK-3849: Automate remaining Scala style rules <https://issues.apache.org/jira/browse/SPARK-3849>.
Please create sub-tasks on this issue for rules that we have not automated and let's work through them as possible. I went ahead and created the first sub-task, SPARK-3850: Scala style: Disallow trailing spaces <https://issues.apache.org/jira/browse/SPARK-3850>. Nick On Tue, Oct 7, 2014 at 4:45 PM, Nicholas Chammas <nicholas.cham...@gmail.com > wrote: > For starters, do we have a list of all the Scala style rules that are > currently not enforced automatically but are likely well-suited for > automation? > > Let's put such a list together in a JIRA issue and work through > implementing them. > > Nick > > On Thu, Oct 2, 2014 at 12:06 AM, Cheng Lian <lian.cs....@gmail.com> wrote: > >> Since we can easily catch the list of all changed files in a PR, I think >> we can start with adding the no trailing space check for newly changed >> files only? >> >> >> On 10/2/14 9:24 AM, Nicholas Chammas wrote: >> >>> Yeah, I remember that hell when I added PEP 8 to the build checks and >>> fixed >>> all the outstanding Python style issues. I had to keep rebasing and >>> resolving merge conflicts until the PR was merged. >>> >>> It's a rough process, but thankfully it's also a one-time process. I >>> might >>> be able to help with that in the next week or two if no-one else wants to >>> pick it up. >>> >>> Nick >>> >>> On Wed, Oct 1, 2014 at 9:20 PM, Michael Armbrust <mich...@databricks.com >>> > >>> wrote: >>> >>> The hard part here is updating the existing code base... which is going >>>> to >>>> create merge conflicts with like all of the open PRs... >>>> >>>> On Wed, Oct 1, 2014 at 6:13 PM, Nicholas Chammas < >>>> nicholas.cham...@gmail.com> wrote: >>>> >>>> Ah, since there appears to be a built-in rule for end-of-line >>>>> whitespace, >>>>> Michael and Cheng, y'all should be able to add this in pretty easily. >>>>> >>>>> Nick >>>>> >>>>> On Wed, Oct 1, 2014 at 6:37 PM, Patrick Wendell <pwend...@gmail.com> >>>>> wrote: >>>>> >>>>> Hey Nick, >>>>>> >>>>>> We can always take built-in rules. Back when we added this Prashant >>>>>> Sharma actually did some great work that lets us write our own style >>>>>> rules in cases where rules don't exist. >>>>>> >>>>>> You can see some existing rules here: >>>>>> >>>>>> >>>>>> https://github.com/apache/spark/tree/master/project/ >>>>> spark-style/src/main/scala/org/apache/spark/scalastyle >>>>> >>>>>> Prashant has over time contributed a lot of our custom rules upstream >>>>>> to stalastyle, so now there are only a couple there. >>>>>> >>>>>> - Patrick >>>>>> >>>>>> On Wed, Oct 1, 2014 at 2:36 PM, Ted Yu <yuzhih...@gmail.com> wrote: >>>>>> >>>>>>> Please take a look at WhitespaceEndOfLineChecker under: >>>>>>> http://www.scalastyle.org/rules-0.1.0.html >>>>>>> >>>>>>> Cheers >>>>>>> >>>>>>> On Wed, Oct 1, 2014 at 2:01 PM, Nicholas Chammas < >>>>>>> >>>>>> nicholas.cham...@gmail.com >>>>>> >>>>>>> wrote: >>>>>>>> As discussed here <https://github.com/apache/spark/pull/2619>, it >>>>>>>> >>>>>>> would be >>>>>> >>>>>>> good to extend our Scala style checks to programmatically enforce as >>>>>>>> >>>>>>> many >>>>>> >>>>>>> of our style rules as possible. >>>>>>>> >>>>>>>> Does anyone know if it's relatively straightforward to enforce >>>>>>>> >>>>>>> additional >>>>>> >>>>>>> rules like the "no trailing spaces" rule mentioned in the linked PR? >>>>>>>> >>>>>>>> Nick >>>>>>>> >>>>>>>> >>>> >> >
