I don't think that using git submodules is a good idea here: - The extra `git submodule init && git submodule update` step can lead to confusing problems in certain workflows. - We'd wind up with many commits that serve only to bump the submodule SHA; these commits will be hard to review since they won't contain line diffs (the author will have to manually provide a link to the diff of code changes).
On Sat, Aug 1, 2015 at 10:08 AM, Matt Goodman <meawo...@gmail.com> wrote: > I think that is a good idea, and slated to happen. At the very least a > README or some such. Is this a use case for git submodules? I am > considering porting some of this to a more general spark-cloud launcher, > including google/aliyun/rackspace. It shouldn't be hard at all given the > current approach for setup/install. > > --Matthew Goodman > > ===================== > Check Out My Website: http://craneium.net > Find me on LinkedIn: http://tinyurl.com/d6wlch > > On Fri, Jul 31, 2015 at 6:50 PM, Patrick Wendell <pwend...@gmail.com> > wrote: > >> Hey All, >> >> I've mostly kept quiet since I am not very active in maintaining this >> code anymore. However, it is a bit odd that the project is >> split-brained with a lot of the code being on github and some in the >> Spark repo. >> >> If the consensus is to migrate everything to github, that seems okay >> with me. I would vouch for having user continuity, for instance still >> have a "shim" ec2/spark-ec2 script that could perhaps just download >> and unpack the real script from github. >> >> - Patrick >> >> On Fri, Jul 31, 2015 at 2:13 PM, Shivaram Venkataraman >> <shiva...@eecs.berkeley.edu> wrote: >> > Yes - It is still in progress, but I have just not gotten time to get to >> > this. I think getting the repo moved from mesos to amplab in the >> codebase by >> > 1.5 should be possible. >> > >> > Thanks >> > Shivaram >> > >> > On Fri, Jul 31, 2015 at 3:08 AM, Sean Owen <so...@cloudera.com> wrote: >> >> >> >> PS is this still in progress? it feels like something that would be >> >> good to do before 1.5.0, if it's going to happen soon. >> >> >> >> On Wed, Jul 22, 2015 at 6:59 AM, Shivaram Venkataraman >> >> <shiva...@eecs.berkeley.edu> wrote: >> >> > Yeah I'll send a note to the mesos dev list just to make sure they >> are >> >> > informed. >> >> > >> >> > Shivaram >> >> > >> >> > On Tue, Jul 21, 2015 at 11:47 AM, Sean Owen <so...@cloudera.com> >> wrote: >> >> >> >> >> >> I agree it's worth informing Mesos devs and checking that there are >> no >> >> >> big objections. I presume Shivaram is plugged in enough to Mesos >> that >> >> >> there won't be any surprises there, and that the project would also >> >> >> agree with moving this Spark-specific bit out. they may also want to >> >> >> leave a pointer to the new location in the mesos repo of course. >> >> >> >> >> >> I don't think it is something that requires a formal vote. It's not >> a >> >> >> question of ownership -- neither Apache nor the project PMC owns the >> >> >> code. I don't think it's different from retiring or removing any >> other >> >> >> code. >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> On Tue, Jul 21, 2015 at 7:03 PM, Mridul Muralidharan < >> mri...@gmail.com> >> >> >> wrote: >> >> >> > If I am not wrong, since the code was hosted within mesos project >> >> >> > repo, I assume (atleast part of it) is owned by mesos project and >> so >> >> >> > its PMC ? >> >> >> > >> >> >> > - Mridul >> >> >> > >> >> >> > On Tue, Jul 21, 2015 at 9:22 AM, Shivaram Venkataraman >> >> >> > <shiva...@eecs.berkeley.edu> wrote: >> >> >> >> There is technically no PMC for the spark-ec2 project (I guess we >> >> >> >> are >> >> >> >> kind >> >> >> >> of establishing one right now). I haven't heard anything from the >> >> >> >> Spark >> >> >> >> PMC >> >> >> >> on the dev list that might suggest a need for a vote so far. I >> will >> >> >> >> send >> >> >> >> another round of email notification to the dev list when we have >> a >> >> >> >> JIRA >> >> >> >> / PR >> >> >> >> that actually moves the scripts (right now the only thing that >> >> >> >> changed >> >> >> >> is >> >> >> >> the location of some scripts in mesos/ to amplab/). >> >> >> >> >> >> >> >> Thanks >> >> >> >> Shivaram >> >> >> >> >> >> > >> >> > >> > >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@spark.apache.org >> For additional commands, e-mail: dev-h...@spark.apache.org >> >> >
