That looks like a change to restore some behavior that was removed in 2.2. It's not directly relevant to a release vote on 2.4.1. See the existing discussion at https://github.com/apache/spark/pull/22144#issuecomment-432258536 It may indeed be a good thing to change but just continue the discussion as you work on your PR.
On Thu, Feb 21, 2019 at 9:09 AM Parth Gandhi <parthkgand...@gmail.com> wrote: > > Hello, > In https://issues.apache.org/jira/browse/SPARK-24935, I am getting > requests from people that they were hoping for the fix to be merged in Spark > 2.4.1. The concerned PR is here: https://github.com/apache/spark/pull/23778. > I do not mind if we do not merge it for 2.4.1 and I do not want to be > considered this as a blocker for 2.4.1, but I would appreciate if somebody > can have a look and decide on the same. I have not written unit tests for the > PR yet, as I am relatively new to Catalyst and was hoping for someone to > confirm whether the fix is progressing in the right direction before > proceeding ahead with the unit tests. Thank you. > > Regards, > Parth Kamlesh Gandhi > > > On Wed, Feb 20, 2019 at 11:34 PM Felix Cheung <felixcheun...@hotmail.com> > wrote: >> >> Could you hold for a bit - I have one more fix to get in >> >> >> ________________________________ >> From: d_t...@apple.com on behalf of DB Tsai <d_t...@apple.com.invalid> >> Sent: Wednesday, February 20, 2019 12:25 PM >> To: Spark dev list >> Cc: Cesar Delgado >> Subject: Re: [VOTE] Release Apache Spark 2.4.1 (RC2) >> >> Okay. Let's fail rc2, and I'll prepare rc3 with SPARK-26859. >> >> DB Tsai | Siri Open Source Technologies [not a contribution] | Apple, Inc >> >> > On Feb 20, 2019, at 12:11 PM, Marcelo Vanzin <van...@cloudera.com.INVALID> >> > wrote: >> > >> > Just wanted to point out that >> > https://issues.apache.org/jira/browse/SPARK-26859 is not in this RC, >> > and is marked as a correctness bug. (The fix is in the 2.4 branch, >> > just not in rc2.) >> > >> > On Wed, Feb 20, 2019 at 12:07 PM DB Tsai <d_t...@apple.com.invalid> wrote: >> >> >> >> Please vote on releasing the following candidate as Apache Spark version >> >> 2.4.1. >> >> >> >> The vote is open until Feb 24 PST and passes if a majority +1 PMC votes >> >> are cast, with >> >> a minimum of 3 +1 votes. >> >> >> >> [ ] +1 Release this package as Apache Spark 2.4.1 >> >> [ ] -1 Do not release this package because ... >> >> >> >> To learn more about Apache Spark, please see http://spark.apache.org/ >> >> >> >> The tag to be voted on is v2.4.1-rc2 (commit >> >> 229ad524cfd3f74dd7aa5fc9ba841ae223caa960): >> >> https://github.com/apache/spark/tree/v2.4.1-rc2 >> >> >> >> The release files, including signatures, digests, etc. can be found at: >> >> https://dist.apache.org/repos/dist/dev/spark/v2.4.1-rc2-bin/ >> >> >> >> Signatures used for Spark RCs can be found in this file: >> >> https://dist.apache.org/repos/dist/dev/spark/KEYS >> >> >> >> The staging repository for this release can be found at: >> >> https://repository.apache.org/content/repositories/orgapachespark-1299/ >> >> >> >> The documentation corresponding to this release can be found at: >> >> https://dist.apache.org/repos/dist/dev/spark/v2.4.1-rc2-docs/ >> >> >> >> The list of bug fixes going into 2.4.1 can be found at the following URL: >> >> https://issues.apache.org/jira/projects/SPARK/versions/2.4.1 >> >> >> >> FAQ >> >> >> >> ========================= >> >> How can I help test this release? >> >> ========================= >> >> >> >> If you are a Spark user, you can help us test this release by taking >> >> an existing Spark workload and running on this release candidate, then >> >> reporting any regressions. >> >> >> >> If you're working in PySpark you can set up a virtual env and install >> >> the current RC and see if anything important breaks, in the Java/Scala >> >> you can add the staging repository to your projects resolvers and test >> >> with the RC (make sure to clean up the artifact cache before/after so >> >> you don't end up building with a out of date RC going forward). >> >> >> >> =========================================== >> >> What should happen to JIRA tickets still targeting 2.4.1? >> >> =========================================== >> >> >> >> The current list of open tickets targeted at 2.4.1 can be found at: >> >> https://issues.apache.org/jira/projects/SPARK and search for "Target >> >> Version/s" = 2.4.1 >> >> >> >> Committers should look at those and triage. Extremely important bug >> >> fixes, documentation, and API tweaks that impact compatibility should >> >> be worked on immediately. Everything else please retarget to an >> >> appropriate release. >> >> >> >> ================== >> >> But my bug isn't fixed? >> >> ================== >> >> >> >> In order to make timely releases, we will typically not hold the >> >> release unless the bug in question is a regression from the previous >> >> release. That being said, if there is something which is a regression >> >> that has not been correctly targeted please ping me or a committer to >> >> help target the issue. >> >> >> >> >> >> DB Tsai | Siri Open Source Technologies [not a contribution] | Apple, >> >> Inc >> >> >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe e-mail: dev-unsubscr...@spark.apache.org >> >> >> > >> > >> > -- >> > Marcelo >> > >> > --------------------------------------------------------------------- >> > To unsubscribe e-mail: dev-unsubscr...@spark.apache.org >> > >> >> >> --------------------------------------------------------------------- >> To unsubscribe e-mail: dev-unsubscr...@spark.apache.org >> --------------------------------------------------------------------- To unsubscribe e-mail: dev-unsubscr...@spark.apache.org
